Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction for retrieving the issuer name for the current request #55

Merged
merged 12 commits into from
Dec 23, 2020
Merged

Add abstraction for retrieving the issuer name for the current request #55

merged 12 commits into from
Dec 23, 2020

Conversation

leastprivilege
Copy link
Member

@leastprivilege leastprivilege commented Dec 21, 2020 •
edited
Loading

  • Adds the IIssuerNameService
  • Sets the issuer name for the current request on the ValidatedRequest object

This will allow removing direct dependencies on IHttpContextAccessor in various places

@leastprivilege leastprivilege added this to the 5.0.0 milestone Dec 21, 2020
@leastprivilege leastprivilege added the enhancement New feature or request label Dec 21, 2020
@brockallen
Copy link
Member

Would there be any reason to make the GetCurrent async? I don't really want to, but I'm trying to anticipate someone asking.

@leastprivilege
Copy link
Member Author

yea..

@leastprivilege
Merge branch 'main' into features/issuer_service
f9e4940 
* main:
  use msft json serializer (away from newtonsoft)
  fix xml comment
  add support for ui_locales on end session endpoint
  implement generic container for persisted grant data column
@leastprivilege
changed to async
6294b14
@leastprivilege
Copy link
Member Author

@brockallen There are various places where we could switch to the new service, but they would be all breaking changes. Let's discuss.

@leastprivilege leastprivilege added internal and removed enhancement New feature or request labels Dec 23, 2020
@leastprivilege leastprivilege self-assigned this Dec 23, 2020
@leastprivilege leastprivilege merged commit 42f4070 into main Dec 23, 2020
@leastprivilege leastprivilege deleted the features/issuer_service branch December 23, 2020 13:29
@brockallen brockallen linked an issue Dec 29, 2020 that may be closed by this pull request
Add service to get issuer #29
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brockallen brockallen Awaiting requested review from brockallen

Assignees

@leastprivilege leastprivilege

Labels
internal
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Add service to get issuer
2 participants
@leastprivilege @brockallen