Use the built-in CSPRNG GetInt32 #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsjones
commented
Jan 19, 2022
| @@ -36,27 +36,7 @@ public class NumericUserCodeGenerator : IUserCodeGenerator | |||
| /// <returns></returns> | |||
| public Task<string> GenerateAsync() | |||
| { | |||
| var next = Next(100000000, 999999999); | |||
| var next = RandomNumberGenerator.GetInt32(100000000, 1000000000); | |||
There was a problem hiding this comment.
The one built in to .NET has an exclusive upper bound, while the previous one was inclusive, hence the upper bound of 1_000_000_000.
|
Yo, it's @vcsjones -- howdy sir! Thanks for visiting our repo :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 3.0+ have this capability built-in, so use that instead of rolling it.