Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest.json #10

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Update manifest.json #10

merged 8 commits into from
Jun 9, 2023

Conversation

alirezaabdi01
Copy link
Contributor

:)

@Dziango
Copy link
Owner

Dziango commented May 18, 2023

Hey there, 2 questions:

  1. Why changing "content_script"'s "matches" value?
  2. Why removing "activeTab" permission? Is it not necessary nowadays?

@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented May 18, 2023

  1. actually i think your content_scripts are better but i think twitch.tv is enough
  2. The codes work without this permission on all the browsers

@Dziango
Copy link
Owner

Dziango commented May 21, 2023

  1. U might be right. I'm not sure why I've put these .ttvnw.net and .twitchcdn.net there. Propably someone requsted that. In the end leaving that there doesn't hurt. Up to you :)
  2. Were you able to confirm that your code does indeed work on firefox when the permission is granted? If that is the case then I see no reason not to merge your changes and upload them to chrome/ff stores :)

Here is the last edit and it works fine with edge and chrome and ff
and also chrome will not support manifest v2 for 2024
@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented May 23, 2023

Here is the last edit and it works fine with edge and chrome and ff
and also I changed manifest version to 2 but chrome and edge will not support manifest v2 for 2024 and later

added homepage_url
@Dziango
Copy link
Owner

Dziango commented May 25, 2023

So, if I understand you correctly, manifest version was reverted back to v2 in order for the extension to work properly on firefox and, at the same time, chrome and edge will stop supporting it by the end of the year. Is that correct?
Do you know why the extension doesn't work on firefox with manifest v2?

@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented May 26, 2023

The codes don't work on ff with manifest v3 because they are adopting v3:

https://blog.mozilla.org/addons/2022/05/18/manifest-v3-in-firefox-recap-next-steps/

w3c/webextensions#134

The codes easily work on chrome and edge with putting manifest version on 3 but for ff we need some codes. The problem is that ff doesn't give permissions automatically anymore to the extensions. So i will test to see if i can request permission on install.

@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented May 26, 2023

I think for now we can put manifest version on 3 for chrome and put manifest version on 2 for ff and see when will ff stop supporting manifest v2
ff is really making everything hard in v3
Although it's not a big deal if we put the manifest version on 3 for ff but user should be smart enough to read our description and active this:
image

@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented May 28, 2023

I researched and it looks like ff's manifest v3 will get completed in September 2023.
So let's publish the codes on chrome with manifest v3 and on ff with manifest v2.
And after ff completed their manifest v3, we will change the codes.

Better twitch url permission fo the future ff codes
@Dziango
Copy link
Owner

Dziango commented Jun 8, 2023

@alirezaabdi01 what do you say we simply go for a manifest v3 straight away? It needs to be done sooner or later anyway, so why not right now.
I'll make sure to edit extension's description in firefox store and include info about permissions.

@alirezaabdi01
Copy link
Contributor Author

alirezaabdi01 commented Jun 8, 2023

The thing is it's akward to tell people to go there, and go there, and active this, do this, do that ....
We have 6 months until 2024 so we can hold to v2 for at least 5 months then surely firefox will finish and publish their v3 in October and we can change the codes to v3 and make the permission process automate or at least much easier like requesting permission on twitch website.
For example I researched for requesting permission on v3 and it's still not ready.
Did you test the codes?
Edit: It's not necessary to put different versions for chrome and ff. V2 is good for both of them for 5 months.

@Dziango Dziango merged commit 00aa02a into Dziango:master Jun 9, 2023
@Dziango
Copy link
Owner

Dziango commented Jun 9, 2023

@alirezaabdi01 Okay, I hear you. Let's do it your way then. We just got to remember about that issue in 5 months :)
Yea, I tested it on Chrome and Firefox and it seems to work correctly.
I've submitted and update for review in both Chrome Web Store and Firefox Add-ons. It may take few days (up to 1 month!) before it's accepted and published.
I'll let you know when that happens :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants