-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA-2343 — Version 2.0.1: Improvements in evidence string duplication, PubMed references, string-to-ontology mapping #202
Conversation
@BaronKoy One change might be of particular interest to you: I have clarified in the manual curation documentation how to handle the case when you need to map a single disease string to multiple ontology terms. It's the “Note on multiple mappings” section in the |
Co-authored-by: April Shen <april.tuesday@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good.
### Note on multiple mappings | ||
Sometimes it is necessary to map a single source string to two or more ontology terms to fully represent the concept. For example, “Coronary artery disease/myocardial infarction” should be mapped both to http://www.ebi.ac.uk/efo/EFO_0001645 “Coronary artery disease” and to http://www.ebi.ac.uk/efo/EFO_0000612 “Myocardial infarction”. | ||
|
||
To do this, **duplicate** the row containing the disease string, assign different mappings in each of the rows, and mark them both with an appropriate status. This will be handled downstream during export and evidence string generation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true for all cases bringing context ? Like "susceptibility to" or "resistance to" or is it limited to a set of trait that are composed of two disease family ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's a very good point. No, as of now it only applies to multiple disease terms. Semantic context would need to be addressed separately at some point in the future (requiring guidance from OT first on how to represent it).
I've added clarifications to the documentation: 12c1dcb
Version 2.0.1 addresses three groups of issues. Issues highlighted in bold contain substantial discussions and are recommended for reading.
Evidence string duplication
Processing PubMed references
Handling string to ontology mappings