Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-2352 — ClinVar investigations #208

Merged
merged 29 commits into from
Mar 24, 2021
Merged

Conversation

tskir
Copy link
Member

@tskir tskir commented Mar 19, 2021

For the report, it's easier to view the updated version rather than read a diff: https://github.com/EBIvariation/eva-opentargets/tree/eva-2352-clinvar-investigations/clinvar-variant-types.

This PR only concerns the updated script and the report. Separate follow-up issues will be created to discuss the findings with the Open Targets team and plan future work, if necessary.

@tskir tskir force-pushed the eva-2352-clinvar-investigations branch from 2c079cb to 3c2ec41 Compare March 20, 2021 02:32
@tskir tskir changed the base branch from master to eva-2359-submission-21-04 March 20, 2021 03:02
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice addition to the parsing libraries.
It illustrates really well the different types of submission that clinvar contains

* Whether it contains no trait records, one record, or multiple;
* Whether at least one of the trait records contains more than one name.

Only traits of type “Disease” are processed by the pipeline and demonstrated in this diagram.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a diagram of the different trait types as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that's an important metric. Thank you for this suggestion, I've now implemented it, and the diagram really looks much more informative. Here's an updated section in the report: https://github.com/EBIvariation/eva-opentargets/tree/eva-2352-clinvar-investigations/clinvar-variant-types#trait-representation

Base automatically changed from eva-2359-submission-21-04 to master March 22, 2021 13:13
@tskir tskir added the Data label Mar 23, 2021
@tskir tskir requested a review from tcezard March 23, 2021 03:33
@tskir tskir merged commit 4ec9bc1 into master Mar 24, 2021
@tskir tskir deleted the eva-2352-clinvar-investigations branch March 25, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment