-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVA-2352 — ClinVar investigations #208
Conversation
4a9dea8
to
2c079cb
Compare
2c079cb
to
3c2ec41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice addition to the parsing libraries.
It illustrates really well the different types of submission that clinvar contains
clinvar-variant-types/README.md
Outdated
* Whether it contains no trait records, one record, or multiple; | ||
* Whether at least one of the trait records contains more than one name. | ||
|
||
Only traits of type “Disease” are processed by the pipeline and demonstrated in this diagram. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth adding a diagram of the different trait types as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, that's an important metric. Thank you for this suggestion, I've now implemented it, and the diagram really looks much more informative. Here's an updated section in the report: https://github.com/EBIvariation/eva-opentargets/tree/eva-2352-clinvar-investigations/clinvar-variant-types#trait-representation
For the report, it's easier to view the updated version rather than read a diff: https://github.com/EBIvariation/eva-opentargets/tree/eva-2352-clinvar-investigations/clinvar-variant-types.
clinvar_xml_utils
.This PR only concerns the updated script and the report. Separate follow-up issues will be created to discuss the findings with the Open Targets team and plan future work, if necessary.