EVA-3322 - refactor #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
requested review from
apriltuesday,
sundarvenkata-EBI and
nitin-ebi
apriltuesday
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
I think this approach makes sense to me, hopefully will encourage us to think more about how we use our internal vs. truly publicly available resources, in addition to the stripped down dependency set for eva-sub-cli...
It's true that it causes some hassle in refactoring/renaming (if we've pinned versions we can at least do it on an as-needed basis?), so if other people think it's not worth the trade-off that would be okay as well.
There was a problem hiding this comment.
config_utils needs to be in internal as well
nitin-ebi
approved these changes
Sep 29, 2023
sundarvenkata-EBI
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this proposal I moved all the function that can only be used within EVA to the ebi_eva_internal_pyutils folder.
I also created a list of additional dependencies that are required to use the internal functions
This will make it clear which package require the additional dependencies and which do not.
However it still requires a fair amount of refactoring in the code that uses the internal functions.