EVA-3590 update initial check for validation required or not #40
Conversation
eva_sub_cli/main.py
Outdated
| return False | ||
| except requests.HTTPError as ex: | ||
| logger.error(f'Error occurred while getting status of the submission with ID {submission_id}: {ex.response.status_code} {ex.response.text}') | ||
| raise |
There was a problem hiding this comment.
I wonder if we should not raise anything here and return true/false depending on the status code and what's safe to do (i.e. 404 should behave like no ID found I guess). Otherwise we need to clearly convey what the user should do when this crashes - try again later? Email helpdesk?
There was a problem hiding this comment.
I see two options:
- Have a sensible default when the API fails to respond ie submission does not exist
- Raising an error that should be caught and exit gracefully with a clear error message
There was a problem hiding this comment.
raising and existing gracefully with msg
eva_sub_cli/main.py
Outdated
| if SUBMIT in tasks: | ||
| if not sub_config.get(READY_FOR_SUBMISSION_TO_EVA, False): | ||
| return True | ||
| else: |
There was a problem hiding this comment.
else: is unnecessary since you return in the if
eva_sub_cli/main.py
Outdated
| except requests.HTTPError as ex: | ||
| logger.error(f'Error occurred while getting status of the submission with ID {submission_id}: {ex.response.status_code} {ex.response.text}') | ||
| raise | ||
| else: |
eva_sub_cli/main.py
Outdated
| return False | ||
| except requests.HTTPError as ex: | ||
| logger.error(f'Error occurred while getting status of the submission with ID {submission_id}: {ex.response.status_code} {ex.response.text}') | ||
| raise |
There was a problem hiding this comment.
I see two options:
- Have a sensible default when the API fails to respond ie submission does not exist
- Raising an error that should be caught and exit gracefully with a clear error message
bin/eva-sub-cli.py
Outdated
| @@ -83,3 +86,7 @@ def get_version(): | |||
| main.orchestrate_process(**args.__dict__) | |||
| except FileNotFoundError as fne: | |||
| print(fne) | |||
| except SubmissionNotFoundException as snfe: | |||
| print(f'{snfe}. Retry with correct submission id. If the problem persists, please contact EVA Helpdesk') | |||
There was a problem hiding this comment.
I'm not sure the user will know the submission ID since it's just stored in the config, there's not a command line option to set it or anything. Since this is just when it's not found in the WS maybe just contact helpdesk in this case.
eva_sub_cli/submission_ws.py
Outdated
|
|
||
| @property | ||
| def _submission_ws_url(self): | ||
| """Retrieve the base URL for the submission web services. In order of preference from the user of this class, |
There was a problem hiding this comment.
| """Retrieve the base URL for the submission web services. In order of preference from the user of this class, | |
| """Retrieve the base URL for the submission web services. In order of preference from |
No description provided.