EVA-3581 Add option to see all errors of all categories for a sample #41
Conversation
nitin-ebi
commented
Jun 13, 2024
•
nitin-ebi
commented
| @@ -1,6 +1,10 @@ | |||
|
|
|||
| {% macro sample_name_check_report(validation_results) -%} | |||
| {% set results = validation_results.get('sample_check', {}) %} | |||
| {% macro format_error(error) %} | |||
| {{ error | replace(' ', '•') }} | |||
There was a problem hiding this comment.
What about other types of whitespace (tabs and maybe newlines)? I guess they're very unlikely particularly in spreadsheets, but may be possible in JSON.
There was a problem hiding this comment.
I kind of agree but I also think it might get complicated to display tab and newline as their specific character.
I would suggest that we think of a more generalised solution (unicode maybe) if that becomes a problem.
There was a problem hiding this comment.
Agree with both.
Also as @apriltuesday said, since they are more likely to occur in json, I think they would be easier to spot as well.
The user will be able to glance at the json file and hopefully will be able to see tab or new line in the value as they will explicitly specified inside double quotes. ("\tValue1" or "\nValue2") which is not the case in a spreadsheet, especially with trailing whitespaces.
There was a problem hiding this comment.
i've updated the template so that the first sheet is selected when opening.
nitin-ebi
force-pushed
the
update_sample_report
branch
from
1ba1f37
to
e061c50
Compare
