EVA-3635 - Fixes from Testing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcezard
commented
Aug 21, 2024
| # Validation is mandatory so if submit is requested then VALIDATE must have run before or be requested as well | ||
| if SUBMIT in tasks: | ||
| if not sub_config.get(READY_FOR_SUBMISSION_TO_EVA, False): | ||
| return True | ||
| submission_id = sub_config.get(SUB_CLI_CONFIG_KEY_SUBMISSION_ID, None) | ||
| if submission_id: | ||
| try: | ||
| submission_status = SubmissionWSClient().get_submission_status(submission_id) | ||
| submission_status = SubmissionWSClient(username, password).get_submission_status(submission_id) |
There was a problem hiding this comment.
Passing the username and password is required because the auth is a global variable and subsequent call will not have the username/password if it is initially created without them.
There was a problem hiding this comment.
I can't remember, did you check whether it worked without the global auth?
There was a problem hiding this comment.
I did try briefly and it didn't work first time so didn't push it since it wasn't pat of this ticket
Raise if metadata spreadsheet is not provided Remove requirement for VCF file type since it has been removed from the metadata Output logs for main nextflow steps to help debug Add debug option to main CLI Lower some docker validator log message to debug
tcezard
force-pushed
the
EVA3635_fix_from_test
branch
from
e6bb427
to
bafae45
Compare
apriltuesday
approved these changes
Aug 29, 2024
| # Validation is mandatory so if submit is requested then VALIDATE must have run before or be requested as well | ||
| if SUBMIT in tasks: | ||
| if not sub_config.get(READY_FOR_SUBMISSION_TO_EVA, False): | ||
| return True | ||
| submission_id = sub_config.get(SUB_CLI_CONFIG_KEY_SUBMISSION_ID, None) | ||
| if submission_id: | ||
| try: | ||
| submission_status = SubmissionWSClient().get_submission_status(submission_id) | ||
| submission_status = SubmissionWSClient(username, password).get_submission_status(submission_id) |
There was a problem hiding this comment.
I can't remember, did you check whether it worked without the global auth?
nitin-ebi
approved these changes
Aug 30, 2024
Co-authored-by: April Shen <april.tuesday@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all relative path are made into full path
Raise if metadata spreadsheet is not provided
Remove requirement for VCF file type since it has been removed from the metadata Output logs for main nextflow steps to help debug
Add debug option to main CLI
Lower some docker validator log message to debug