Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3663_cli_Documentation #59

Merged
merged 7 commits into from
Sep 17, 2024
Merged

EVA-3663_cli_Documentation #59

merged 7 commits into from
Sep 17, 2024

Conversation

Dona094
Copy link
Contributor

@Dona094 Dona094 commented Sep 16, 2024

No description provided.

@Dona094 Dona094 self-assigned this Sep 16, 2024
Copy link
Contributor

@apriltuesday apriltuesday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just did some proofreading and left a couple optional suggestions.

README.md Outdated Show resolved Hide resolved

The path to the VCF files are provided in the Files section of the metadata and their corresponding fasta sequence is provided in the analysis section.
This allows us to support different assemblies for each VCF file.
Please check the below sections `The metadata spreadsheet` and `The metadata JSON` for the format and options available in metadata files.

### The metadata spreadsheet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit for the following lines:
The metadata template can be found within the [etc folder](eva_sub_cli/etc/EVA_Submission_template.xlsx). It should be populated following the instruction provided within the template.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
### Submit only

All submission must have been validated. You cannot run the submission without validation. Once validated running
All submission must have been validated. You cannot run the submission without validation. Once validated, execute the following command

```shell
eva-sub-cli.py --metadata_xlsx metadata_spreadsheet.xlsx --submission_dir submission_dir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit for the last line of the file:
This will only submit the data and not validate.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved


## Installation

There are currently three ways to install and run the tool: using conda, from source using Docker,
and from source natively (i.e. managing dependencies on your own).
There are currently three ways to install and run the tool :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's some cultural differences in spacing for colons... I don't mind either way, as long as we're consistent.

### Using metadata file by providing `--metadata_json` or `--metadata_xlsx`
| OPTIONS/PARAMETERS | DESCRIPTION |
|----------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| --version | Shows version number of the program and exit |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I've edited the --help text in the code... we can transfer those edits here but it's not a big deal.

Dona094 and others added 2 commits September 17, 2024 17:16
Co-authored-by: April Shen <ashen@ebi.ac.uk>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Timothee Cezard <tcezard@ebi.ac.uk>
@apriltuesday apriltuesday merged commit 835012b into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants