Skip to content

Commit

Permalink
Fix lint-reported errors on GitHub actions (#621)
Browse files Browse the repository at this point in the history
Fix some lint-reported errors on GitHub actions.
By default yamllint will check keys for truthy: reporting useless
errors, like for GitHub actions:
https://yamllint.readthedocs.io/en/stable/rules.html#module-yam
llint.rules.truthy
  • Loading branch information
gwarf authored Nov 14, 2023
1 parent 7d1fe54 commit 1e94f6b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
2 changes: 2 additions & 0 deletions .github/linters/.yaml-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ extends: default
rules:
line-length:
max: 120
truthy:
check-keys: false
16 changes: 8 additions & 8 deletions .github/workflows/deploy_pr_preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,22 @@ jobs:
with:
script: |
var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
owner: context.repo.owner,
repo: context.repo.repo,
run_id: ${{github.event.workflow_run.id }},
owner: context.repo.owner,
repo: context.repo.repo,
run_id: ${{github.event.workflow_run.id }},
});
var matchArtifact = artifacts.data.artifacts.filter((artifact) => {
return artifact.name == "pr"
})[0];
var download = await github.rest.actions.downloadArtifact({
owner: context.repo.owner,
repo: context.repo.repo,
artifact_id: matchArtifact.id,
archive_format: 'zip',
owner: context.repo.owner,
repo: context.repo.repo,
artifact_id: matchArtifact.id,
archive_format: 'zip',
});
var fs = require('fs');
fs.writeFileSync('${{github.workspace}}/pr.zip',
Buffer.from(download.data));
Buffer.from(download.data));
- name: Extract pull request preview
id: extract
Expand Down

1 comment on commit 1e94f6b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@check-spelling-bot Report

🔴 Please review

See the 📜action log or 📝 job summary for details.

❌ Errors Count
❌ no-files-to-check 1

See ❌ Event descriptions for more information.

Please sign in to comment.