Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move hillslope variables off surface dataset #2434

Draft
wants to merge 2 commits into
base: b4b-dev
Choose a base branch
from

Conversation

samsrabin
Copy link
Contributor

@samsrabin samsrabin commented Mar 22, 2024

Work in progress! Do not review!

Subject to force pushes!

Description of changes

This PR moves the variables required for hillslope runs off the surface dataset and onto the new hillslope_file. This makes it so we don't have to maintain a hillslope-specific surface dataset for testing purposes. If/when running with hillslopes becomes the default, we can move these variables back onto the surface dataset.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

  • Derecho hillslope tests are b4b-identical with ctsm5.1.dev174
  • Izumi hillslope tests are b4b-identical with ctsm5.1.dev174
  • Other Derecho and Izumi aux_clm tests are b4b-identical with ctsm5.1.dev174

Remaining work

  • Merge in 5.2 tag
  • Update surface dataset specified in Hillslope testmod: Use default 10x15 fsurdat
  • Update synthetic hillslope dataset specified in Hillslope testmod, if needed

@samsrabin samsrabin added the type: enhancement new capability or improved behavior of existing capability label Mar 22, 2024
@samsrabin samsrabin self-assigned this Mar 22, 2024
@samsrabin samsrabin added the tag: simple bfb easy to fix, bit-for-bit label Mar 22, 2024
@samsrabin samsrabin added the blocked: dependency Wait to work on this until dependency is resolved label Mar 25, 2024
@samsrabin
Copy link
Contributor Author

Blocked: Waiting on 5.2.

@samsrabin samsrabin removed the blocked: dependency Wait to work on this until dependency is resolved label May 2, 2024
@samsrabin
Copy link
Contributor Author

5.2 is in, so this is no longer blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: simple bfb easy to fix, bit-for-bit type: enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant