Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New updates on MEGANv2.1 #2588

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HuiWangWanderInGitHub
Copy link

@HuiWangWanderInGitHub HuiWangWanderInGitHub commented Jun 7, 2024

Description of changes

We added new features to MEGANv2.1 for simulating isoprene emissions based on three recent studies conducted at the BAI lab in the University of California, Irvine. The first one is about the drought impact on isoprene (Wang et al., 2022). The second study investigates the effect of temperature history on the emission factors of boreal broadleaf deciduous shrubs (Wang et al., 2024a). The third study explores a different temperature response curve for C3 Arctic grass (Wang et al., 2024b, under press). These changes improved the model's representation of isoprene emissions during drought and in high-latitude ecosystems.
This work is related to issue #1323 and is based on the old MEGANv2.1 framework, but incorporates new scientific insights.

Specific notes

We modified the impact of drought based on the water stress function (β) in the CLM model. We adopted equation (11) from Wang et al., (2022) as:
image
, where a1 (=-7.45) and b1(=3.26) are empirical parameters. The function “get_gamma_SM” is modified to simulate the change of substrate supply under the water stress.
Second and third modifications are for the high-latitude isoprene emitters including boreal broadleaf deciduous shrubs (BBDS) and C3 Arctic grass (C3AG). These results come from the Biogenic Emission and Aerosol Response on the North Slope (BEAR-oNS) project. These modifications are implemented in “get_gamma_T” function in the code.
For the BBDS, we included the adaptation of isoprene emission factors to the mean temperature of the previous day with the quation as:
image
, where T24 (K) denotes the mean air temperature of the preceding day (Wang et al., 2024a).
For the C3AG, we adopted a dynamic temperature response curve adapted to the record of growing temperature as:
image
. CC3AG is the activation energy for the isoprene temperature response of C3AG and changes with the mean air temperature of the preceding 10 days (T240) as:
image.
The impact of T240 on isoprene emission factor of C3AG is as:
image.

Any User Interface Changes (namelist or namelist defaults changes)?
NO.
Does this create a need to change or add documentation? Did you do so?
I could provide the modification to the scientific document for these changes after they have been added.

Testing performed, if any:
I tested the code on Derecho with the I2000Clm50BgcCrop compsets, and it ran well. The scientific impact of the code for isoprene flux estimations can be found in the corresponding references.

Reference

Wang, H., Lu, X., Seco, R., Stavrakou, T., Karl, T., Jiang, X., et al. (2022). Modeling isoprene emission response to drought and heatwaves within MEGAN using evapotranspiration data and by coupling with the community land model. Journal of Advances in Modeling Earth Systems, 14, e2022MS003174. https://doi.org/10.1029/2022MS003174
Wang, H., Welch, A. M., Nagalingam, S., Leong, C., Kittitananuvong, P., Barsanti, K. C., et al. (2024a). Arctic heatwaves could significantly influence the isoprene emissions from shrubs. Geophysical Research Letters, 51, e2023GL107599. https://doi.org/10.1029/2023GL107599
Wang, H., Welch, A. M., Nagalingam, S., Leong, C., Czimczik, C., Tang, J., et al. (2024b): High temperature sensitivity of Arctic isoprene emissions explained by sedges (accepted by Nature Communications, in press).

@wwieder
Copy link
Contributor

wwieder commented Jun 10, 2024

Thanks for opening this PR @HuiWangWanderInGitHub.

We'll start reviewing this PR, but a quick look seems like this should be straightforward to implement.
In the meantime, I also would like to ask that you open a PR that updates the MEGAN documentation in the CTSM technical note.

Directions for this are posted on the wiki

@olyson, can you help with this?

@wwieder wwieder added this to the CESM3 Capability Freeze milestone Jun 10, 2024
@wwieder wwieder added priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations tag: enh - new science enhancement that brings in new science capabilities tag: next this should get some attention in the next week or two labels Jun 10, 2024
@wwieder
Copy link
Contributor

wwieder commented Jun 10, 2024

Purely samantic question, can we call this PR MEGANv2.2, or is this confusing with broader MEGAN documentation?

Also @lkemmons, can you help clarify the prioritization of this PR in relation to the science code freeze (July 31 deadline) for cam-chem?

@olyson
Copy link
Contributor

olyson commented Jun 11, 2024

There is a more condensed version of how to update the documentation here:

https://docs.google.com/document/d/1aLlu6C6DJiiO2T21qnj54WFCYuSdGw9F/edit

Once you've issued a PR for the new documentation and verified the documentation builds successfully, we can take it from there.

@lkemmons
Copy link

lkemmons commented Jun 13, 2024 via email

@wwieder wwieder added this to Slow roast (incremental or external progress) in CTSM-CLM6 development highlights Jun 17, 2024
@samsrabin samsrabin removed the tag: next this should get some attention in the next week or two label Jun 20, 2024
Bring tmp-branch to master

Bring in changes that came in on the tmp-240620 branch to master now that cesm3_0_beta01 has been made.

The changes are documented in tags and the ChangeLog but include the following tags:

  tmp-240620.n03.ctsm5.2.007 samrabin -- upland hillslope column fsat values to zero
  tmp-240620.n02.ctsm5.2.007 erik ------ Another update of git-fleximod
  tmp-240620.n01.ctsm5.2.007 slevis ---- Merge b4b-dev
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jul 6, 2024

@HuiWangWanderInGitHub
I updated my local copy of this branch to the latest clm tag and tried to push to the PR, but I do not have permissions. Could you add me as collaborator? Instructions:
Click on your branch CLM5_MEGAN_ISOP at the top of this screen, then Settings, then "Collaborators" and you should see a way to add me as a collaborator there.
UPDATE: collaborator access granted, thank you!

./run_sys_tests -s aux_clm -c ctsm5.2.008 --skip-generate
aux_clm test-suite on derecho FAIL (see next post)
aux_clm on izumi FAIL (same as derecho)

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Jul 7, 2024

Large number of tests differ from the baseline (see /glade/derecho/scratch/slevis/tests_0706-132231de).

  • Most variables with diffs have the MEG_ prefix or _voc suffix, which seems expected.
  • Some do not, but only in two tests:
ERS_D_Ld15.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdTwoStream
PEM_D_Ld9.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam6LndTuningMode

The former has diffs in FATES variables (clm file) and in lndImp variables (cpl file).
The latter has diffs in the cism file, which seems somewhat related to #2542.
For now I will let others weigh in with an assessment of these results.

UPDATE 1: Same result on izumi with
ERS_D_Ld15.f45_f45_mg37.I2000Clm50FatesRs.izumi_nag.clm-FatesColdTwoStream
having diffs in FATES variables (clm file) and in lndImp variables (cpl file).

UPDATE 2: I tried the 3 failing tests in vanilla ctsm5.2.008:
All pass against baseline.
The ERS tests fail with COMPARE_base_rest (expected).
The PEM test fails with COMPARE_base_modpes (expected).

UPDATE 3: I backed out my last commit and repeated the 3 tests:
On derecho the PEM test still failed.
On derecho and izumi the ERS test now passed.

This reverts commit d940ee0
because answers were changing from the baseline in tests
ERS_D_Ld15.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdTwoStream
ERS_D_Ld15.f45_f45_mg37.I2000Clm50FatesRs.izumi_nag.clm-FatesColdTwoStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations tag: enh - new science enhancement that brings in new science capabilities
Projects
Status: Slow roast (incremental or external progress)
Status: In Progress
CTSM-CLM6 development highlights
  
Slow roast (incremental or external p...
Development

Successfully merging this pull request may close these issues.

None yet

6 participants