-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Base GDD20 on per-gridcell windows, not per-hemisphere #2593
Draft
samsrabin
wants to merge
121
commits into
ESCOMP:scale-maturity-reqs
Choose a base branch
from
samsrabin:scale-mat-reqs-pr2-ggcmiseas
base: scale-maturity-reqs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Base GDD20 on per-gridcell windows, not per-hemisphere #2593
samsrabin
wants to merge
121
commits into
ESCOMP:scale-maturity-reqs
from
samsrabin:scale-mat-reqs-pr2-ggcmiseas
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids different "nearest neighbors" being chosen when using a different number of processors. See https://github.com/orgs/esmf-org/discussions/261
This is hopefully not something that will be needed permanently or even in the medium term, so it's not worth cleaning up and unit-/system-testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress! Do not review!
Description of changes
In the existing code, when using the default CLM crop calendars,
gddmaturity
(maturity requirement; the number of growing degree-days it takes for a crop to mature and be harvested) can vary within some bounds based on climate over the past 20 years. Specifically, CLM looks at some annual "warm period" which differs between the northern and southern hemispheres. This variation allows "farmers" to adapt the "cultivars" (varieties) they grow based on recent climate.When prescribing maturity requirement, though—with input file
stream_fldFileName_cultivar_gdds
—it's currently not allowed to vary over time. Instead, it's locked in to what's provided in the input file: the mean GDD accumulation in the GGCMI growing period over the 1980-2009 growing seasons.We want this variation to allow "farmers" to adapt the "varieties" they grow based on whether the recent climate has been warmer or cooler than that baseline 1980-2009 period.
This PR represents the second step toward adding that ability. I'm breaking this work up into separate PRs to keep them manageable:
gddmaturity
values to a realistic range.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Not unless enabling this new, experimental feature.
Any User Interface Changes (namelist or namelist defaults changes)?
stream_gdd20_seasons
(default false). Enabling this automatically sets the relevant input files (see below) to the half-degree GGCMI growing seasons.stream_fldFileName_gdd20_season_start
and_end
(default''
, unlessstream_gdd20_seasons
is true). Providing either file butstream_gdd20_seasons = .true.
will cause an error in the build namelist step.Does this create a need to change or add documentation? Did you do so? Documentation will need to be updated when all the PRs in my plan are merged and this feature is considered ready for use. But at this point, things are preliminary enough that I'd have to rewrite whatever docs I added in this PR. So no: I'm adding no documentation here.
Testing performed, if any: