Update submodule tags to pass runoff from CISM to ROF as per issue #2590

[slevis-lmwg]

Description of changes

Details in #2590

Specific notes

Contributors other than yourself, if any:
@ekluzek @mvertens @jedwards4b @billsacks

CTSM Issues Fixed (include github issue #):
Fixes #2590

Are answers expected to change (and if so in what way)?
Yes, due to change in default behavior

Any User Interface Changes (namelist or namelist defaults changes)?
Default behavior has changed as explained in #2590

Does this create a need to change or add documentation? Did you do so?
Probably, but I did not.

[slevis-lmwg]

From the TODO list in the issue
Most of aux_clm and ctsm_sci is failing for now.

UPDATE: Trying aux_clm on izumi
FAIL, so try bisecting between the latest tags that I used versus the branch hashes that I pointed to when the tests passed

[slevis-lmwg]

Bisecting between my passing and failing aux_clm test-suites:

• no code diffs between rtm1_0_80 and 420c5979d8abf05184992fdfba5ac41c41c91c2e
• no code diffs between mosart1.1.02 and ca0acc0336365456bec653c4c233abb57d9bc62d
• large code diffs between cmeps0.14.67 and 4dca7c602e54189b74b1d0195c433d1b83475553
  Here ESCOMP/CMEPS@f960f3e I see that I may have had to have used cmeps0.14.77
  @jedwards4b I should have checked with you which tag to use, for this one and the next one. I have resubmitted aux_clm on izumi already, so I hope to know by tomorrow, but pls let me know if you think that I'm still off.
• ccs_config now I see here ESMCI/ccs_config_cesm@4e337b5 that I may have had to have used ccs_config_cesm1.0.0
• cism should be fine because I asked @Katetc specifically which tag to use

[slevis-lmwg]

aux_clm on izumi now OK
./cs.status.fails | grep -v 'otherwise bit-for-b' | grep -v NLCOMP | grep -v 'EXPECTED FAILURE' | grep -v PASS

on derecho
aux_clm tests_0703-123700de
./cs.status.fails | grep -v 'wise bit-for-bit' | grep -v NLCOMP | grep -v 'EXPECTED FAILURE' | grep -v PASS

    FAIL ERS_Ly3_P64x2.f10_f10_mg37.IHistClm50BgcCropG.derecho_intel.clm-cropMonthOutput BASELINE cismtorof.n01_ctsm5.2.007: DIFF
    FAIL SMS_Lm37.f10_f10_mg37.I1850Clm50SpG.derecho_intel.clm-glcMEC_long BASELINE cismtorof.n01_ctsm5.2.007: DIFF

In the first of these two, the largest NORMALIZED DIFF is
ERS_Ly3_P64x2.f10_f10_mg37.IHistClm50BgcCropG.derecho_intel.clm-cropMonthOutput.C.0703-123700de_int.clm2.h0.1852-12.nc.cprnc.out: RMS ERRH2OSNO 2.5269E-17 NORMALIZED 7.0110E-02
And in the latter, the largest NORMALIZED DIFF is
SMS_Lm37.f10_f10_mg37.I1850Clm50SpG.derecho_intel.clm-glcMEC_long.C.0703-123700de_int.cism.gris.h.0004-01-01-00000.nc.cprnc.out: RMS calving_rate 2.2858E-14 NORMALIZED 7.6445E-12
I interpret both as roundoff diffs that have grown over time.

ctsm_sci tests_0703-123641de
./cs.status.fails |grep -v NLCOMP|grep -v 'EXPECTED FAILURE'|grep -v 'wise bit-for-bit'

    FAIL ERP_D_Ld5.f09_g17.I2000Clm50Vic.derecho_intel.clm-vrtlay BASELINE ctsm_sci-ctsm5.2.007: DIFF
    FAIL ERP_Ld5.f09_g17.I2000Clm50Vic.derecho_intel.clm-vrtlay BASELINE ctsm_sci-ctsm5.2.007: DIFF
    FAIL SMS_D_Ld3_PS.f09_g17.I1850Clm60SpNoAnthro.derecho_intel.clm-decStart1851_noinitial BASELINE ctsm_sci-ctsm5.2.007: DIFF
    FAIL SMS_Ld1.f19_g17.I2000Clm50Vic.derecho_intel.clm-default BASELINE ctsm_sci-ctsm5.2.007: DIFF
    FAIL SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial BASELINE ctsm_sci-ctsm5.2.007: DIFF

In the last of these, I see larger diffs including in variables that I would not have expected initially. This is the only Bgc case here. Should I expect changes in CH4 variables as a result of the changes in river flow @swensosc?

SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS CH4PROD                          1.4435E-12            NORMALIZED  7.6136E-03
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS CH4_SURF_AERE_SAT                6.8893E-14            NORMALIZED  9.1275E-02
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS CH4_SURF_DIFF_SAT                5.9901E-12            NORMALIZED  4.6836E-02
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS CH4_SURF_EBUL_SAT                1.5077E-11            NORMALIZED  5.6659E-02
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS FCH4                             3.5318E-16            NORMALIZED  2.9839E-04
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS FCH4TOCO2                        2.1029E-13            NORMALIZED  3.5289E-04
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS FCH4_DFSAT                       3.5660E-16            NORMALIZED  5.2060E+00
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS FINUNDATED                       6.8805E-05            NORMALIZED  8.7284E-03
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS NEM                              1.3188E-12            NORMALIZED  2.6262E-03
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS TOTCOLCH4                        8.2472E-08            NORMALIZED  2.3369E-04
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS TWS                              1.5401E+00            NORMALIZED  1.0340E-04
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS VOLR                             2.0453E+07            NORMALIZED  2.1061E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS VOLRMCH                          2.0453E+07            NORMALIZED  2.1061E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.clm2.h0.1852-01-02-00000.nc.cprnc.out: RMS CONC_O2_SAT                      4.8355E-06            NORMALIZED  3.8462E-03
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.cpl.hi.1852-01-02-00000.nc.cprnc.out: RMS lndExp_Flrr_volr                 1.0665E-03            NORMALIZED  4.0627E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.cpl.hi.1852-01-02-00000.nc.cprnc.out: RMS lndExp_Flrr_volrmch              1.0665E-03            NORMALIZED  4.0627E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.cpl.hi.1852-01-02-00000.nc.cprnc.out: RMS rofImp_Flrr_volr                 1.5704E-03            NORMALIZED  5.9480E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.cpl.hi.1852-01-02-00000.nc.cprnc.out: RMS rofImp_Flrr_volrmch              1.5704E-03            NORMALIZED  5.9480E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.cpl.hi.1852-01-02-00000.nc.cprnc.out: RMS rofImp_Forr_rofl                 7.2396E-06            NORMALIZED  1.0973E+01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.rtm.h0.1851-12.nc.cprnc.out: RMS QCHANR                           3.5056E+01            NORMALIZED  3.3240E-01
SMS_Ld3_PS.f09_g17.I1850Clm60BgcNoAnthro.derecho_intel.clm-decStart1851_noinitial.C.0703-123641de_int.rtm.h0.1851-12.nc.cprnc.out: RMS QCHOCNR                          7.3298E+00            NORMALIZED  2.3645E+00

[slevis-lmwg]

@swensosc verified by email that these diffs seem reasonable. Sean wrote:
I think you would see changes in methane due to the fact that the riley et al. method for calculating inundation uses a regression against TWS to determine the inundated fraction, which is an input to the methane model. So if VOLR is changed, TWS would be changed, and thus methane would see a perturbed inundated area.