Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Binding-Scripts get generated for Packaged UXMLs #16

Closed
siglocpp opened this issue Jun 17, 2022 · 2 comments
Closed

Bug: Binding-Scripts get generated for Packaged UXMLs #16

siglocpp opened this issue Jun 17, 2022 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@siglocpp
Copy link
Contributor

I found an interesting bug, while generating some new UIs:
Rosalina somehow generated Binding Files for some pre-packaged uxmls inside of the unity-core. (see Screenshot).
image

I'm not quite sure how to reproduce this issue, but it happened to me now twice, after restarting unity.

I think, we need something like a Path-Filter on which uxmls to interprete, to prevent things like that from happening.
I suggest., that everything outside of the Assets-Folder should be ignored by default.

siglocpp pushed a commit to siglocpp/Rosalina that referenced this issue Jun 17, 2022
@Eastrall Eastrall added the bug Something isn't working label Jun 17, 2022
@Eastrall
Copy link
Owner

Eastrall commented Jun 17, 2022

Indeed, since there is no filter on any folder here, all .uxml files are taken.

string[] uiFilesChanged = importedAssets
.Where(x => Path.GetExtension(x) == UIDocumentExtension)
.ToArray();

This might happen when you re-import every assets in your project and thus, Unity's internal UIDocuments.
Thanks to your PR (#17) this might fix the issue. 😄

siglocpp pushed a commit to siglocpp/Rosalina that referenced this issue Jun 19, 2022
Eastrall added a commit that referenced this issue Jun 19, 2022
refs #16: filters all files, which are not part of the Asset folder
@Eastrall
Copy link
Owner

Closing this issue. Solved in PR #17

@Eastrall Eastrall added this to the Version 1.1.0 milestone Jun 19, 2022
crowdoka pushed a commit to crowdoka/Rosalina that referenced this issue Dec 7, 2023
crowdoka pushed a commit to crowdoka/Rosalina that referenced this issue Dec 7, 2023
crowdoka pushed a commit to crowdoka/Rosalina that referenced this issue Dec 7, 2023
refs Eastrall#16: filters all files, which are not part of the Asset folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants