Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Revised) - [HacktoberFest2023]: Added cpp.chat and No Diagnostic Required podcast under C++ podcasts section #10512

Conversation

honey-speaks-tech
Copy link
Contributor

What does this PR do?

Add resources

For resources

Description

  • Added link to cpp.chat podcast
  • Added link to No Diagnostic Required podcast

Why is this valuable (or not)?

  • cpp.chat and No Diagnostic Required are great C++ podcasts which brings some C++ news, interviews with C++ community members etc

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

  • N.A

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@Ashu104
Copy link
Contributor

Ashu104 commented Oct 19, 2023

hey @honey-speaks-tech
you haven't passed some check on your commit because of avoiding the alphabetical ordering and remove trailing slash on your commit. try to change them.
you can refer. -->
63:3-63:61 warning Remove trailing slash (https://nodiagnosticrequired.tv/) no-url-trailing-slash remark-lint
62:3-62:32 warning Remove trailing slash (https://cpp.chat/) no-url-trailing-slash remark-lint
1-63:118 warning Alphabetical ordering: swap l.62 and l.61 alphabetize-lists remark-lint

@eshellman eshellman added the waiting for changes PR has been reviewed and changes/suggestions requested label Oct 19, 2023
Copy link
Contributor

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@honey-speaks-tech honey-speaks-tech changed the title [HacktoberFest2023]: Added cpp.chat and No Diagnostic Required podcast under C++ podcasts section (Revised) - [HacktoberFest2023]: Added cpp.chat and No Diagnostic Required podcast under C++ podcasts section Oct 20, 2023
@honey-speaks-tech
Copy link
Contributor Author

@eshellman @Ashu104 Fixed the lint issue in this PR. But an issue blocking the merge which was already reported by someone here in the issue 10557
I have skimmed through this file, but unable to understand what is to be done as it is in a different language. So waiting until the issue is fixed. I have commented on the issue as a "show-stopper" for many PRs.

@eshellman eshellman closed this Oct 21, 2023
@eshellman eshellman reopened this Oct 21, 2023
@eshellman
Copy link
Collaborator

linter issue fixed, closed/opened to rebuild

@eshellman eshellman merged commit f0cc9ca into EbookFoundation:main Oct 21, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants