Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL free-programming-books-ar.md file #6706

Merged
merged 6 commits into from
Feb 10, 2022
Merged

RTL free-programming-books-ar.md file #6706

merged 6 commits into from
Feb 10, 2022

Conversation

AhmedElTabarani
Copy link
Contributor

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

Add RTL to display it correctly on the website.

For resources

Description

Why is this valuable (or not)?

image

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@davorpa davorpa added the 🚀 ready to merge LGTM. Waiting for final approval label Feb 9, 2022
@davorpa

This comment was marked as resolved.

@davorpa davorpa added waiting for changes PR has been reviewed and changes/suggestions requested and removed 🚀 ready to merge LGTM. Waiting for final approval labels Feb 9, 2022
@AhmedElTabarani
Copy link
Contributor Author

could you configure GH pages environment in your fork to check how renders really in fact. An image is not enough.

https://ahmedeltabarani.github.io/free-programming-books/books/free-programming-books-ar.html

I host it at main branch, not in docs/repo-statistics-badges

it works fine, but there are some mistakes

image

We can leave this pull request until Superman comes and fixes it
The page is changing from Markdown to HTML, So we can't modify it in the HTML, we must modify it in the markdown and this requires to add some HTML inside the markdown file to fix it

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Feb 9, 2022

I solve it by add span but it is allowed in travis checking ?

Screenshot 2022-01-31 023219

The result:

image

The problem with the last one, I can't force it to swap
image

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Feb 9, 2022

image

The second problem with that, we must swap the two strings, (swap red and blue)

i do my best here, the solution well be swap them manually, but that not a good solution I think

@eshellman
Copy link
Collaborator

I would strongly prefer not to have markup within a list item, and these are now being parsed to extract metadata for search.

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Feb 9, 2022

I would strongly prefer not to have markup within a list item, and these are now being parsed to extract metadata for search.

There is no another solution except swap them manually, so you can close this pr, and open an issue about it

This will affect on other RTL languages so

@eshellman
Copy link
Collaborator

isn't there a unicode solution? https://en.wikipedia.org/wiki/Right-to-left_mark

@AhmedElTabarani
Copy link
Contributor Author

isn't there a unicode solution? https://en.wikipedia.org/wiki/Right-to-left_mark

i will check it out

@davorpa
Copy link
Member

davorpa commented Feb 10, 2022

isn't there a unicode solution? https://en.wikipedia.org/wiki/Right-to-left_mark

i will check it out

Remember revert/hard reset previous to this commit 3b54340 😉

Eric, I love use non printable entities too and see the magic change

@AhmedElTabarani
Copy link
Contributor Author

AhmedElTabarani commented Feb 10, 2022

This is AMAZING, I love this RLM Unicode
https://ahmedeltabarani.github.io/free-programming-books/books/free-programming-books-ar.html

can add a section talking about this solution in Guidelines in CONTRIBUTING

Now we can do the same with the courses file
And if a section was set up to explain this solution
Other contributors can do the same with their own RTL languages

@@ -34,15 +36,15 @@
* [مدخل إلى الذكاء الاصطناعي وتعلم الآلة](https://academy.hsoub.com/files/17-%D9%85%D8%AF%D8%AE%D9%84-%D8%A5%D9%84%D9%89-%D8%A7%D9%84%D8%B0%D9%83%D8%A7%D8%A1-%D8%A7%D9%84%D8%A7%D8%B5%D8%B7%D9%86%D8%A7%D8%B9%D9%8A-%D9%88%D8%AA%D8%B9%D9%84%D9%85-%D8%A7%D9%84%D8%A2%D9%84%D8%A9/) - Mohamed Lahlah (PDF)


### <a name="csharp"></a>C\#
### <a name="csharp"></a>C#&lrm;
Copy link
Member

@davorpa davorpa Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was rattled about removing the \# escape character but I will also say that after testing, it is just equal valid. In other words, good enhacement to bypass markdownlint MD003 rule with ATX style using other way.

Copy link
Contributor Author

@AhmedElTabarani AhmedElTabarani Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we just use span with id ? to avoid \#.

### <span id="csharp">C#&lrm;</span>

C#‎

honestly, i did not understand what do you exactly want with the style of ATX 🤔😢

@davorpa davorpa self-requested a review February 10, 2022 14:42
@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Feb 10, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even in GitHub integrated file preview

image

@davorpa davorpa added the question Needs clarification by involved users / reviewers label Feb 10, 2022
@davorpa
Copy link
Member

davorpa commented Feb 10, 2022

can add a section talking about this solution in Guidelines in CONTRIBUTING
....
And if a section was set up to explain this solution Other contributors can do the same with their own RTL languages

It'll be great!! making reference to some example, this PR number (#6706) or link provided by Eric. The best place will be in format examples, I thought.

Now we can do the same with the courses file

Open another PR or do it here if you want. Both are valid 😆

@AhmedElTabarani
Copy link
Contributor Author

Open another PR or do it here if you want. Both are valid 😆

I can't do the same with other languages, I might make mistakes
Other contributors can do the same with their own RTL languages

@eshellman eshellman merged commit 82cdf70 into EbookFoundation:main Feb 10, 2022
@davorpa davorpa added 🗣️ locale:ar Resources addressing "Arabic / العربية" language 🐛 BUG Confirmed bugs, normally at GitHub Pages labels Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG Confirmed bugs, normally at GitHub Pages question Needs clarification by involved users / reviewers 🗣️ locale:ar Resources addressing "Arabic / العربية" language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants