Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Solidity" to the table of contents. #6751

Merged

Conversation

Luc1d1ty
Copy link
Contributor

@Luc1d1ty Luc1d1ty commented Mar 6, 2022

No description provided.

@CleanMachine1 CleanMachine1 requested review from davorpa and eshellman and removed request for davorpa March 6, 2022 21:32
@CleanMachine1
Copy link
Member

Solidity is under the sub-category of Java, I don't know whether it should be or not. I have never heard of the language and from my 10 seconds of searching it seems to be its own programming language, am I correct saying this @Luc1d1ty

@Luc1d1ty
Copy link
Contributor Author

Luc1d1ty commented Mar 7, 2022

Yes . It's a programming language of it's own , used for writing smart contracts . And it shouldn't be under the sub category of java as they are completely different from each other .

@davorpa
Copy link
Member

davorpa commented Mar 7, 2022

Nice catch. Thanks for improving TOC. It's sure there are more 🤣

Solidity is under the sub-category of Java, I don't know whether it should be or not. I have never heard of the language and from my 10 seconds of searching it seems to be its own programming language, am I correct saying this @Luc1d1ty

According to the rest of listings, Solidity has it own H3 section, not H4 under Java

@davorpa davorpa added 🗣️ locale:en Resources addressing "English" language 🚀 ready to merge LGTM. Waiting for final approval labels Mar 7, 2022
@Luc1d1ty
Copy link
Contributor Author

Luc1d1ty commented Mar 7, 2022

You are welcome . As this is my very first 'actual' contribution to a big project on github , I am more than happy . As I added only 2 words , I am really hopping to add more than that near future :)

@Luc1d1ty
Copy link
Contributor Author

Luc1d1ty commented Mar 7, 2022

If you don't mind I have a question, ( I am not yet that much expert using github ) I am unable to merge pull request . Is this a problem from my side ? if yes then please assist me to solve the problem . Thank you .

@davorpa
Copy link
Member

davorpa commented Mar 7, 2022

If you don't mind I have a question, ( I am not yet that much expert using github ) I am unable to merge pull request . Is this a problem from my side ? if yes then please assist me to solve the problem . Thank you .

@Luc1d1ty don't be afraid. There are no problems.

Normally, pull request are contributions made on other repositories you haven't write access rights

In this repo Ready to merge label means aproved by staff and waiting to be merged by one with those permissions. (mainly @eshellman )

@Luc1d1ty
Copy link
Contributor Author

Luc1d1ty commented Mar 7, 2022

Got it ! Thank you .

@eshellman
Copy link
Collaborator

I see what happened - the section was added before Spring, not realizing that was in the java section.

Not that we need to also move the list out of the java section, not only the heading.

@eshellman eshellman added waiting for changes PR has been reviewed and changes/suggestions requested and removed 🚀 ready to merge LGTM. Waiting for final approval labels Mar 7, 2022
@Luc1d1ty
Copy link
Contributor Author

Luc1d1ty commented Mar 7, 2022

Got it ! Working on it now .

Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

@eshellman eshellman merged commit aefe5ec into EbookFoundation:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗣️ locale:en Resources addressing "English" language waiting for changes PR has been reviewed and changes/suggestions requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants