Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an AWS free complete course in Arabic #6752

Merged
merged 14 commits into from
Mar 31, 2022

Conversation

EzzOps
Copy link
Contributor

@EzzOps EzzOps commented Mar 6, 2022

this course is totally free, detailed up to 55 hours

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

this course is totally free, detailed up to 55 hours
@EzzOps EzzOps closed this Mar 6, 2022
@davorpa davorpa added 🗣️ locale:ar Resources addressing "Arabic / العربية" language linter error Please, correct build errors found by linter! labels Mar 7, 2022
@davorpa davorpa reopened this Mar 7, 2022
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
@davorpa davorpa added the waiting for changes PR has been reviewed and changes/suggestions requested label Mar 7, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good moment to apply some changes. When done, request for a review again using GitHub 🔃 button. Meanwhile, draft status can be used to work on it if you want.

@CleanMachine1
Copy link
Member

Considering that @ezz444 closed the PR originally I think its most likely a good idea to finish this PR making the relevant suggestions or to close it.

@davorpa davorpa removed the waiting for changes PR has been reviewed and changes/suggestions requested label Mar 29, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra spaces between title and link markdown markup

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
@davorpa davorpa added the stale Requests that have not had recent interaction (Out-of-Date) label Mar 29, 2022
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Alphabetize attemp 1

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Alphabetize attemp 2

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
Copy link
Member

@davorpa davorpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Alphabetize attempt 3

books/free-programming-books-ar.md Outdated Show resolved Hide resolved
books/free-programming-books-ar.md Outdated Show resolved Hide resolved
@davorpa
Copy link
Member

davorpa commented Mar 29, 2022

Considering that @ezz444 closed the PR originally I think its most likely a good idea to finish this PR making the relevant suggestions or to close it.

Done @CleanMachine1!!

I suppose that seeing at a glance the PR was linter faults, he/she closes it. It's a normal situation for newbies working with GitHub. I only recover it because is a interesant resource and with it we fill step by step this listing with few items

Could you review again?

@davorpa davorpa added question Needs clarification by involved users / reviewers and removed linter error Please, correct build errors found by linter! labels Mar 29, 2022
@davorpa davorpa added 🚀 ready to merge LGTM. Waiting for final approval and removed question Needs clarification by involved users / reviewers labels Mar 31, 2022
@davorpa davorpa changed the title Adding a free complete course in Arabic Add an AWS free complete course in Arabic Mar 31, 2022
@eshellman
Copy link
Collaborator

Thanks, and welcome to free-programming-books!

It's usually not helpful to add a category for a single resource. But I'm going to merge this, because the category headings for this list need some work, perhaps translating to arabic. Would welcome help from interested arabic users.

@eshellman eshellman merged commit 7e891f6 into EbookFoundation:main Mar 31, 2022
@AhmedElTabarani
Copy link
Contributor

@davorpa, @eshellman this is a course, not a book
We should move it to courses folder

@davorpa
Copy link
Member

davorpa commented Aug 5, 2022

@davorpa, @eshellman this is a course, not a book We should move it to courses folder

Go ahead then using other PR and referencing this PR number!

@EbookFoundation EbookFoundation locked as resolved and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 ready to merge LGTM. Waiting for final approval 🗣️ locale:ar Resources addressing "Arabic / العربية" language stale Requests that have not had recent interaction (Out-of-Date)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants