Fix according to review

EchoEllet · Mar 28, 2023 · 1b275b0 · 1b275b0
1 parent fa60614
commit 1b275b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,8 +1,6 @@
 ## [next]
 
-- Add `NumberBox` widget. ([#560](https://github.com/bdlukaa/fluent_ui/issues/560) [#771](https://github.com/bdlukaa/fluent_ui/pull/771))
-- Add `min`/`max` properties to the `NumberBox` widget. ([#789](https://github.com/bdlukaa/fluent_ui/pull/789))
-- Allow `NumberBox` Widget to accept int and double values and mathematical expressions. ([#789](https://github.com/bdlukaa/fluent_ui/pull/789))
+- Add `NumberBox` widget. ([#560](https://github.com/bdlukaa/fluent_ui/issues/560) [#771](https://github.com/bdlukaa/fluent_ui/pull/771) [#789](https://github.com/bdlukaa/fluent_ui/pull/789))
 - Add support for `routerConfig` to `FluentApp.router` ([#781](https://github.com/bdlukaa/fluent_ui/issues/781))
 - Add source code for `Show InfoBar` in example application. ([#785](https://github.com/bdlukaa/fluent_ui/pull/785))
 - Make `color` optional in `FluentApp.router`. ([#782](https://github.com/bdlukaa/fluent_ui/issues/782))

diff --git a/lib/src/controls/form/number_box.dart b/lib/src/controls/form/number_box.dart
@@ -228,6 +228,7 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
     _dismissOverlay();
     focusNode!.removeListener(_handleFocusChanged);
     _internalNode?.dispose();
+    controller.dispose();
     super.dispose();
   }
 
@@ -266,7 +267,7 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
 
     if (oldWidget.value != widget.value) {
       if (widget.value != null) {
-        updateController(widget.value!);
+        _updateController(widget.value!);
       } else {
         controller.text = '';
       }
@@ -425,34 +426,34 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
   void incrementSmall() {
     final value = (num.tryParse(controller.text) ?? widget.value ?? 0) +
         widget.smallChange;
-    updateController(value);
+    _updateController(value);
     updateValue();
   }
 
   void decrementSmall() {
     final value = (num.tryParse(controller.text) ?? widget.value ?? 0) -
         widget.smallChange;
-    updateController(value);
+    _updateController(value);
     updateValue();
   }
 
   void incrementLarge() {
     final value = (num.tryParse(controller.text) ?? widget.value ?? 0) +
         widget.largeChange;
-    updateController(value);
+    _updateController(value);
     updateValue();
   }
 
   void decrementLarge() {
     final value = (num.tryParse(controller.text) ?? widget.value ?? 0) -
         widget.largeChange;
-    updateController(value);
+    _updateController(value);
     updateValue();
   }
 
-  void updateController(num value) {
+  void _updateController(num value) {
     controller
-      ..text = format(value) ?? ''
+      ..text = _format(value) ?? ''
       ..selection = TextSelection.collapsed(offset: controller.text.length);
   }
 
@@ -484,7 +485,7 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
         value = value?.toDouble();
       }
 
-      controller.text = format(value) ?? '';
+      controller.text = _format(value) ?? '';
     }
     previousValidValue = value;
 
@@ -493,7 +494,7 @@ class NumberBoxState<T extends num> extends State<NumberBox<T>> {
     }
   }
 
-  String? format(num? value) {
+  String? _format(num? value) {
     if (value == null) return null;
     if (value is int) {
       return value.toString();