Merge pull request #1118 from Aylie-Chou/bug-cannot-share-to-line

Set correct file type to intent after download file from uri & solve issue#1115
EddyVerbruggen · Aug 30, 2020 · 5c385d0 · 5c385d0
2 parents 7c070c7 + 6191590
commit 5c385d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/android/nl/xservices/plugins/SocialSharing.java b/src/android/nl/xservices/plugins/SocialSharing.java
@@ -440,6 +440,9 @@ private Uri getFileUriAndSetType(Intent sendIntent, String dir, String image, St
           }
         }
         saveFile(getBytes(connection.getInputStream()), dir, filename);
+        // update file type
+        String fileType = getMIMEType(image);
+        sendIntent.setType(fileType);
       } else {
         saveFile(getBytes(webView.getContext().getAssets().open(image)), dir, filename);
       }

diff --git a/src/ios/SocialSharing.m b/src/ios/SocialSharing.m
@@ -813,7 +813,9 @@ -(NSString*) storeInFile: (NSString*) fileName
                 fileData: (NSData*) fileData {
   NSArray *paths = NSSearchPathForDirectoriesInDomains(NSDocumentDirectory, NSUserDomainMask, YES);
   NSString *documentsDirectory = [paths objectAtIndex:0];
-  NSString *filePath = [documentsDirectory stringByAppendingPathComponent:fileName];
+  // remove filename wrapping quotes
+  NSString *filenameWithoutQuote = [fileName stringByReplacingOccurrencesOfString:@"'" withString:@""];
+  NSString *filePath = [documentsDirectory stringByAppendingPathComponent:filenameWithoutQuote];
   [fileData writeToFile:filePath atomically:YES];
   _tempStoredFile = filePath;
   return filePath;