Skip to content

Commit

Permalink
iOS: Any plan to remove UIWebView and use WKWebView instead? #1052
Browse files Browse the repository at this point in the history
  • Loading branch information
EddyVerbruggen committed Sep 5, 2019
1 parent 2d832a7 commit bee99af
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,9 @@ Sharing an image (only images from the internet are supported). If you pass more
```

## 7. Share-popover on iPad

> This no longer works since plugin version 5.5.0, see [this issue](https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052).
Carlos Sola-Llonch, a user of this plugin, pointed me at an [iOS document](https://developer.apple.com/library/ios/documentation/uikit/reference/UIActivityViewController_Class/Reference/Reference.html)
stating "On iPad, you must present the view controller in a popover. On iPhone and iPod touch, you must present it modally."

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-x-socialsharing",
"version": "5.4.7",
"version": "5.5.0",
"description": "Share text, images (and other files), or a link via the native sharing widget of your device. Android is fully supported, as well as iOS 6 and up. WP8 has somewhat limited support.",
"cordova": {
"id": "cordova-plugin-x-socialsharing",
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="cordova-plugin-x-socialsharing"
version="5.4.7">
version="5.5.0">

<name>SocialSharing</name>

Expand Down
4 changes: 4 additions & 0 deletions src/ios/SocialSharing.m
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ - (void)available:(CDVInvokedUrlCommand*)command {
}

- (NSString*)getIPadPopupCoordinates {
// see https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052
return nil;
/*
if (_popupCoordinates != nil) {
return _popupCoordinates;
}
Expand All @@ -39,6 +42,7 @@ - (NSString*)getIPadPopupCoordinates {
// prolly a wkwebview, ignoring for now
return nil;
}
*/
}

- (void)setIPadPopupCoordinates:(CDVInvokedUrlCommand*)command {
Expand Down
1 change: 1 addition & 0 deletions www/SocialSharing.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ SocialSharing.prototype.iPadPopupCoordinates = function () {
};

SocialSharing.prototype.setIPadPopupCoordinates = function (coords) {
console.log("Deprecated - setIPadPopupCoordinates no longer works since plugin version 5.5.0. See https://github.com/EddyVerbruggen/SocialSharing-PhoneGap-Plugin/issues/1052");
// left,top,width,height
cordova.exec(function() {}, this._getErrorCallback(function() {}, "setIPadPopupCoordinates"), "SocialSharing", "setIPadPopupCoordinates", [coords]);
};
Expand Down

0 comments on commit bee99af

Please sign in to comment.