Use Facebook URL instead of File when present #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Note that this will functionally change behavior of the plugin. In a patch release. Is that really what we should do? |
|
I believe we should because without this the image file itself is the click destination for Facebook rather than the URL. This at least keeps the sharing feature of the plugin working.
…On Apr 13, 2020, 3:43 PM -0400, Eddy Verbruggen ***@***.***>, wrote:
Thanks! Note that this will functionally change behavior of the plugin. In a patch release. Is that really what we should do?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
If anything, this sounds like a better default anyway. Thanks again! |
|
Would you mind releasing the 5.6.5 milestone now? I'd like to incorporate this official package into our next release with this merge. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.