Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filter option for "facsimile available" #361

Merged
merged 14 commits into from
Sep 16, 2020
Merged

add filter option for "facsimile available" #361

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
496fa18
first shot at implementing #359
peterstadler Sep 14, 2020
f8c10a4
allow for multiple values
peterstadler Sep 15, 2020
2920d2f
improve counting
peterstadler Sep 15, 2020
30f5ab2
fixes processing of multiple values for one param
peterstadler Sep 15, 2020
4b8974f
make use of the `api:validate-*` functions for checking the sanity of…
peterstadler Sep 15, 2020
8b5bd0c
silently drop empty strings
peterstadler Sep 15, 2020
137639f
some code refactoring
peterstadler Sep 15, 2020
ef47459
update expected results
peterstadler Sep 15, 2020
dc35fd4
fix expected result
peterstadler Sep 15, 2020
21e9df5
yet another fix for multiple values
peterstadler Sep 16, 2020
156ead0
add translation of facsimile facet
peterstadler Sep 16, 2020
b740ee9
add facsimile facet to writings list view
peterstadler Sep 16, 2020
2406255
fix propagation of dates
peterstadler Sep 16, 2020
449494f
output zero for unavailable options
peterstadler Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
silently drop empty strings 
for fromDate and toDate
  • Loading branch information
@peterstadler
peterstadler committed Sep 15, 2020
commit 8b5bd0ce71aa58e7abe192775c34b753625f3984
2 changes: 2 additions & 0 deletions modules/api.xqm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ declare function api:validate-limit($model as map()) as map()? {
~:)
declare function api:validate-fromDate($model as map()) as map()? {
if($model('fromDate') castable as xs:date) then $model
else if($model?fromDate ='') then () (: an empty string is simply dropped :)
else error($api:INVALID_PARAMETER, 'Unsupported date format given: "' || $model('fromDate') || '". Should be YYYY-MM-DD.')
};

Expand All @@ -373,6 +374,7 @@ declare function api:validate-fromDate($model as map()) as map()? {
~:)
declare function api:validate-toDate($model as map()) as map()? {
if($model('toDate') castable as xs:date) then $model
else if($model?toDate ='') then () (: an empty string is simply dropped :)
else error($api:INVALID_PARAMETER, 'Unsupported date format given: "' || $model('toDate') || '". Should be YYYY-MM-DD.')
};

Expand Down