Create Python package & bump to Python 3.8 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien2012eng
requested review from
desilinguist,
mulhod,
slava92,
Frost45,
ksteimel and
tamarl08
mulhod
reviewed
Sep 14, 2022
| transformers==4.11.3 | ||
| scikit-learn==0.20.0 | ||
| sentencepiece==0.1.95 | ||
| allennlp==0.9.0 |
There was a problem hiding this comment.
I know you mentioned this but just for the record, I would like to confirm that upgrading to 0.9.0 has no impact on gector's results?
There was a problem hiding this comment.
@damien2012eng did you see this message?
mulhod
approved these changes
Sep 14, 2022
mulhod
suggested changes
Sep 14, 2022
|
Yes. I compared the predictions over 100 sentences. No differences are found. |
mulhod
approved these changes
Sep 14, 2022
Frost45
approved these changes
Sep 14, 2022
desilinguist
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.