Some small fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billboard.ChartData has no member previous_date but it does have a previousDate member. Passing in that value instead.
Small typo in Billboard where author had `self.song_list = self.song_list.append(foo)`. `list.append` returns a None type object so original author was inadvertently removing the list they intended to append to.
Song.artist is not a method and is already an Artist so no need for the extra parens
Readme incorrectly stated that Genre had callable members get_song_list and get_artist_list
Raise a NoLyricsException when a search in format "artist:song" does not return a link to that song.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Edward.
Awesome library you have here, I really like the API. I came across a few small typo-level issues while I was working with it so I've corrected them. I'm submitting this pull request so that you can fix the version you have up on pypi if you choose to do so.
Cheers!
Eli