Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: remove emitter #4532

Merged
merged 1 commit into from
May 2, 2017
Merged

Conversation

QingWei-Li
Copy link
Contributor

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

试验了下还是不错的,可以去掉 emitter 了

Copy link
Contributor

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不错不错

@baiyaaaaa baiyaaaaa merged commit fff7ddd into ElemeFE:dev May 2, 2017
Leopoldthecoder added a commit to Leopoldthecoder/element that referenced this pull request May 3, 2017
@Leopoldthecoder
Copy link
Contributor

Reverting this as broadcast cannot be replaced with provide / inject.

Leopoldthecoder added a commit that referenced this pull request May 3, 2017
bluejfox added a commit to setariajs/setaria-ui that referenced this pull request May 25, 2017
* commit '68edc75da1d81c17dbafb303cc54997f3c31ee5f': (36 commits)
  [release] 1.3.0
  [build] 1.3.0
  Changelog: update for 1.3.0
  Dialog: fix visible.sync compatibility with before-close
  table: set width for each td>div.cell.el-tooltip element(ElemeFE#2198,ElemeFE#3128)
  ColorPicker: empty value by v-model, fix ElemeFE#4662
  fix uploading progress text style
  fix uploading style bug
  Form: Add label slot
  DatePicker: fix, add test for default-value
  [release] 1.3.0-beta.3
  [build] 1.3.0-beta.3
  Changelog: update for 1.3.0-beta.3
  add .sync support for Dialog and Pagination
  fix datepicker test, revert emitter-removing attempt
  Revert "Form: remove emitter (ElemeFE#4532)"
  Table: add tests for summary row (ElemeFE#4543)
  Table: Add filter-placement for table filter Popper; If the column is too wide, the popper's position will be improper; https://jsfiddle.net/whitewang/obpsLcva/7/
  Table: Add filter-placement for table filter Popper; If the column is too wide, the popper's position will be improper; https://jsfiddle.net/whitewang/obpsLcva/7/
  Update PULL_REQUEST_TEMPLATE.md
  ...

# Conflicts:
#	CHANGELOG.zh-CN.md
#	examples/versions.json
#	package.json
#	packages/message-box/src/main.js
#	packages/upload/src/upload-list.vue
#	src/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants