Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blinded payments are no longer experimental (and other BOLT updates along the way) #6138

Conversation

rustyrussell
Copy link
Contributor

No description provided.

@rustyrussell rustyrussell added this to the v23.05 milestone Apr 1, 2023
@rustyrussell rustyrussell changed the title Blinded payments are not experimental (and other BOLT updates along the way) Blinded payments are no longer experimental (and other BOLT updates along the way) Apr 1, 2023
@rustyrussell rustyrussell force-pushed the guilt/onionpay-not-experimental branch from a7bb355 to be623f5 Compare April 2, 2023 06:01
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be623f5

It's in the main bolt, so remove qualifies from the bolt quote so they
are checked.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Too much context, it didn't apply if you try to rebuild from source!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
"BOLT 4: Remove legacy format, make var_onion_optin compulsory."

This also renamed the redundant "tlv_payload" to "payload", so we
replace "tlv_tlv_payload" with "tlv_payload" everyhere!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
"Allow nodes to overshoot the MPP `total_msat` when paying (ElementsProject#1031)"

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Changed: Protocol: Allow slight overpaying, even with MPP, as spec now recommends.
"Allow nodes to overshoot final htlc amount and expiry (ElementsProject#1032)"

Note that this also renamed `min_final_cltv_expiry` to the more-correct
`min_final_cltv_expiry_delta`.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
"BOLT 04: remove associated data from test vector"

(We actually use merge point).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
"BOLT 03: fix static-remote same amt and pre-image test vector"

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In particular:
	- Bolt 4: add route blinding construction
	- Bolt 4: add blinded payments

And this means it's not experimental, so we can turn it on
by default!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: Protocol: blinded payments are now supported by default (not just with `--experimental-onion-messages`)
@rustyrussell rustyrussell force-pushed the guilt/onionpay-not-experimental branch from be623f5 to c7419fd Compare April 7, 2023 06:57
@rustyrussell
Copy link
Contributor Author

Fixed trivial backwards payment test which caused all payments to fail!

Ack c7419fd

@rustyrussell rustyrussell merged commit d4ffc75 into ElementsProject:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants