offer: expose a way to derive a payer-id from the metadata #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/derive_payer_id_rpc
branch
from
fbf8330
to
9f3f61d
Compare
The `invreq_payerid` is obtained during the offer fetching process by tweaking the bolt12 public key (which is derived from the main secret). Currently, there exists no means to validate our bolt 12 invoice as there is no public API accessible for retrieving the bolt12 public key and performing the necessary tweak. So, this commit introduces the functionality to address this limitation. Changelog-Added: offer: expose a way to derive a payer-id from the metadata Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/derive_payer_id_rpc
branch
from
9f3f61d
to
f1056ec
Compare
This was referenced Mar 23, 2024
vincenzopalazzo
force-pushed
the
macros/derive_payer_id_rpc
branch
from
3db4913
to
2b7c585
Compare
This commit is adding a test for the predecessor commit to verify that we are able to add the node (payer) public key inside the invoice request. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
vincenzopalazzo
force-pushed
the
macros/derive_payer_id_rpc
branch
from
2b7c585
to
6f410eb
Compare
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
|
This has changed, so it would now be possible. In particular I changed it to be a tweak of our node id, based on a secret you can get via makesecret. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
invreq_payeridis obtained during the offer fetching process by tweaking the bolt12 public key (which is derived from the main secret).Currently, there exists no means to validate our bolt 12 invoice as there is no public API accessible for retrieving the bolt12 public key and performing the necessary tweak.
So, this commit introduces the functionality to address this limitation.
This should be an valid alternative to this #7123
I finger out that I reading code skill are better than reading and understand a bolt, I am arriving the point of full understand bolt12 (maybe)