Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectd throttle #7366

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Connectd throttle #7366

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
37f5796
lightningd: log BROKEN if we lost funds, only unusual if we closed ab…
rustyrussell Jun 4, 2024
cffefba
ccan: update for more efficient ccan/io.
rustyrussell Jun 4, 2024
df35780
wire: optimize sending packets now we can return EAGAIN.
rustyrussell Jun 4, 2024
864fea2
devtools/gossipwith: use timestamp filter message not obsolete INIT_R…
rustyrussell Jun 4, 2024
2c28a21
connectd: throttle streaming gossip for peers.
rustyrussell Jun 4, 2024
45d37c3
gossipd: delete empty gossipd_peerd_wire.csv
rustyrussell Jun 4, 2024
6da54de
gossmap: add linear streaming interface.
rustyrussell Jun 4, 2024
3e513f1
connectd: use gossmap streaming interface.
rustyrussell Jun 4, 2024
0c9ab1e
gossipd: drop zlib support.
rustyrussell Jun 4, 2024
e5cfbe6
connectd: do response to gossip queries, don't hand them to gossipd.
rustyrussell Jun 4, 2024
8a52e9e
connectd: tie gossip query responses into ratelimiting code.
rustyrussell Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lightningd: log BROKEN if we lost funds, only unusual if we closed ab… 
…andoned HTLC.

Started seeing these in my logs, and it's the wrong way around!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
@rustyrussell
rustyrussell committed Jun 4, 2024
commit 37f5796d6006b8cdf16173eed6fe006e55ba3650
7 changes: 4 additions & 3 deletions lightningd/peer_htlcs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,7 +1435,7 @@ static void fulfill_our_htlc_out(struct channel *channel, struct htlc_out *hout,
/* Did we abandon the incoming? Oops! */
if (hout->in->failonion) {
/* FIXME: Accounting? */
log_unusual(channel->log, "FUNDS LOSS of %s: peer took funds onchain before we could time out the HTLC, but we abandoned incoming HTLC to save the incoming channel",
log_broken(channel->log, "FUNDS LOSS of %s: peer took funds onchain before we could time out the HTLC, but we abandoned incoming HTLC to save the incoming channel",
fmt_amount_msat(tmpctx, hout->msat));
} else {
struct short_channel_id scid = channel_scid_or_local_alias(hout->key.channel);
Expand Down Expand Up @@ -1752,8 +1752,9 @@ void onchain_failed_our_htlc(const struct channel *channel,
? fromwire_peektype(hout->failmsg)
: 0);
} else {
log_broken(channel->log, "HTLC id %"PRIu64" is from nowhere?",
htlc->id);
/* This happens if we abandoned the incoming HTLC to avoid closure */
log_unusual(channel->log, "HTLC id %"PRIu64" is from nowhere: did we abandon it?",
htlc->id);

/* Immediate corruption sanity check if this happens */
htable_check(&ld->htlcs_out->raw, "onchain_failed_our_htlc out");
Expand Down
Loading