Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluggable types: BAM #6

Closed
michaeltneylon opened this issue Apr 24, 2019 · 3 comments
Closed

pluggable types: BAM #6

michaeltneylon opened this issue Apr 24, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@michaeltneylon
Copy link
Contributor

use pysam to support BAM type by reading into SAM format before diff. Make it an optional installation since it requires an extra dependency.

@michaeltneylon michaeltneylon added the enhancement New feature or request label Apr 24, 2019
@michaeltneylon
Copy link
Contributor Author

I did a small proof of this locally and it works fine, but I had not made it pluggable. This is the part I want to get working better, so we can do something like pip install pytest-cromwell[bam]

@jdidion
Copy link
Collaborator

jdidion commented Apr 24, 2019

The [bam] part is just a matter of adding to setup.py

extras_require={
  "bam": ["pysam"]
}

michaeltneylon added a commit that referenced this issue Apr 24, 2019
demonstrates use of the plugin for bam type
jdidion pushed a commit that referenced this issue May 3, 2019
demonstrates use of the plugin for bam type
@jdidion
Copy link
Collaborator

jdidion commented May 3, 2019

Implemented by #10

@jdidion jdidion closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants