Update libgit2 #422
Merged
Update libgit2 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustsec has been really slow updating to a version with git 0.14 to resolve a segfault, which also blocked cargo-deny. Instead, we now handle all git fetching ourselves so we are no longer blocked, now or in the future. This also changes it so that we use crates-index as a dependency as previously we had included this functionality directly as at the time crates-index didn't support bare repositories.
MarijnS95
reviewed
May 17, 2022
| @@ -133,19 +133,6 @@ jobs: | |||
| - name: cargo publish | |||
| run: cargo publish --dry-run | |||
|
|
|||
| msrv-check: | |||
| name: Minimum Stable Rust Version Check | |||
There was a problem hiding this comment.
This is still useful even if rust-version is set, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #380
Resolves: #410