Allow non-HTTPS Git URLs for the advisory database #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
The check was apparently added because
rustsec
doesn't support non-HTTPS URLs, butcargo-deny
doesn't actually userustsec
to fetch the repo;cargo-deny
fetches it itself with thegit2
crate or thegit
executable and then passes the repo torustsec
as a local filesystem path. And indeed, after removing the check I'm able to use anssh://
URL for the advisory database without any problem. So, as far as I can see, the check is unnecessarily restrictive.