Improve workspace dependencies lints #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves workspace-duplicates and unused-workspace-dependencies to be in the bans.workspace-dependencies section, and adds an additional include-path-dependencies field (defaults to false) that determines if path dependencies in workspace members are checked for using workspace = true
…t doesn't really matter
Jake-Shadle
force-pushed
the
fixup-workspace-check
branch
from
ee0a97d
to
95c8efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
workspace-duplicatesandunused-workspace-dependenciesto be in the[bans.workspace-dependencies]section, and adds an additionalinclude-path-dependenciesfield (defaults to true) that determines if path dependencies in workspace members are checked for usingworkspace = true. Since the whole section is now opt-in, bothduplicatesandunusedaredenyby default.Resolves: #682