fix: Reset focus after route #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This returns focus back to <body>, which, while not ideal, is what happens in a non-SPA.
|
Any progress? |
|
Hi |
|
MERGED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This addresses #25 partly)
This returns focus back to , which, while not ideal, is what would happen in a non-SPA.
For users of screenreaders, I'd say this is better than doing nothing at all.
As I mentioned in #25, I see this as a first step, with the second step being a mechanism to move focus intentionally (and/or something that automates it, as found in Reach).