Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resync i18n-tasks config with default, make it work on cy files #3434

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tbhi
Copy link
Contributor

@tbhi tbhi commented Feb 21, 2024

No description provided.

@ldodds
Copy link
Collaborator

ldodds commented Feb 21, 2024

It would be helpful to be able to identify missing/incorrect interpolations in the Welsh files within the existing structure. But moving the files around will cause issues with synching requiring every key and file to be reviewed. Missing translations to be expected while we are waiting for translation work to be done. We shouldn't be creating our own Welsh text via google translate, etc.

##
## To implement your own, please see `I18n::Tasks::Scanners::AstMatchers::BaseMatcher`.
<%# I18n::Tasks.add_ast_matcher('I18n::Tasks::Scanners::AstMatchers::RailsModelMatcher') %>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this does nothing

tried enabling the matcher via line 101 below but this causes i18n-tasks health to stacktrace

@tbhi tbhi changed the title update i18n-tasks config, make it work on cy files resync i18n-tasks config with default, make it work on cy files Feb 21, 2024
@ldodds ldodds added the blocked label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants