Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style buttons #3944

Draft
wants to merge 32 commits into
base: 4486-integrate-new-colour-palette
Choose a base branch
from
Draft

Conversation

urbanwide
Copy link
Contributor

@urbanwide urbanwide commented Oct 2, 2024

On the whole I have tried to:

  • Where there is view, edit and delete buttons together. view has become primary, edit secondary and delete danger.
  • In other cases, there has only been edit and delete buttons, in which case they are edit primary and delete danger.
  • I have left in some btn-warning (yellow) where I think it is appropriate but I may have missed some.
  • I have styled btn-success as per the teal button in the design. See what you think
  • The outline buttons currently have a white background. I think this looks better than transparent. Some buttons on the original design have transparent backgrounds though so not sure which option to go with.
  • I have removed the used of btn-outline-dark and associated friends (btn-outline-dark rounded-pill font-weight-bold) previously used to style our outline button. I have replaced it (and friends) with btn-default for now, as didn't want to loose the placeholder. btn-default has has the same style as the base btn.

image

Button groups

I have changed the default (accidental) styling for button groups as we had soo many button groups and I didn't want to remove the grouping all together. So btn-group still groups buttons together but if you want to make it look like they are in a panel (i.e. not rounded in between buttons), you now need to add the panel class too. I thought it would be better to choose where we wanted to do this rather than accidentally have this all over the site.

image

Radio buttons, checkboxes, range and progress

image

@ldodds ldodds changed the base branch from master to 4486-integrate-new-colour-palette October 3, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant