-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style buttons #3944
Draft
urbanwide
wants to merge
32
commits into
4486-integrate-new-colour-palette
Choose a base branch
from
4486-style-buttons
base: 4486-integrate-new-colour-palette
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Style buttons #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldodds
changed the base branch from
master
to
4486-integrate-new-colour-palette
October 3, 2024 10:02
urbanwide
force-pushed
the
4486-style-buttons
branch
from
October 3, 2024 11:46
5180243
to
85a322e
Compare
…m again if need be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the whole I have tried to:
Button groups
I have changed the default (accidental) styling for button groups as we had soo many button groups and I didn't want to remove the grouping all together. So btn-group still groups buttons together but if you want to make it look like they are in a panel (i.e. not rounded in between buttons), you now need to add the panel class too. I thought it would be better to choose where we wanted to do this rather than accidentally have this all over the site.
Radio buttons, checkboxes, range and progress