-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise DicomObject abstraction #524
base: master
Are you sure you want to change the base?
Commits on Jun 29, 2024
-
[object] Redesign DicomObject trait
- use GAT on Element type - add element_opt and element_by_name_opt
Configuration menu - View commit details
-
Copy full SHA for e3f85b7 - Browse repository at this point
Copy the full SHA e3f85b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a90a325 - Browse repository at this point
Copy the full SHA a90a325View commit details -
[object] Redesign DicomObject trait
- add DicomAttributeValue trait, use it as output of most methods in DicomObject - rename methods and add new ones in DicomObject - use GATs for the attribute value, item and pixel data types - reimplement DicomObject
Configuration menu - View commit details
-
Copy full SHA for 4fdfe04 - Browse repository at this point
Copy the full SHA 4fdfe04View commit details -
[object] Extend DicomObject a bit more
- provide access to items and pixel data fragments - require DicomAttributeValue to impl DicomValueType - add a few tests
Configuration menu - View commit details
-
Copy full SHA for 16769e3 - Browse repository at this point
Copy the full SHA 16769e3View commit details -
[object] Rearrange DicomAttribute
- rename from DicomAttributeValue - add `to_i32` and `to_u16`
Configuration menu - View commit details
-
Copy full SHA for e018470 - Browse repository at this point
Copy the full SHA e018470View commit details -
[object] Remove DicomObject::meta
- instead, meta attributes can be retrieved like any other attribute
Configuration menu - View commit details
-
Copy full SHA for 53bd0b2 - Browse repository at this point
Copy the full SHA 53bd0b2View commit details -
[object] Reiterate on DicomObject
- replace `to_dicom_value` with `to_primitive_value` - simplifies implementations and requires consumers to depend on other methods when working with sequences - remove method `meta` - treat meta information attributes like any other attribute, retrievable through the same methods - [core] add either crate - impl many DICOM traits to `either::Either` - implement DicomObject for FileMetaTable - reimplement DICOM traits for FileDicomObject so that users can retrieve either meta info or main data set info
Configuration menu - View commit details
-
Copy full SHA for c757898 - Browse repository at this point
Copy the full SHA c757898View commit details
Commits on Jul 13, 2024
-
[core] Tweak Value::shallow_clone
- elide lifetime - fix formatting of doc comments
Configuration menu - View commit details
-
Copy full SHA for eae2801 - Browse repository at this point
Copy the full SHA eae2801View commit details