Address review comments

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
EngFlow · Nov 27, 2023 · 8d34bab · 8d34bab
1 parent 5d14941
commit 8d34bab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/analyzer/java/com/engflow/bazel/invocation/analyzer/dataproviders/FlagValueDataProvider.java b/analyzer/java/com/engflow/bazel/invocation/analyzer/dataproviders/FlagValueDataProvider.java
@@ -23,6 +23,7 @@
 import com.engflow.bazel.invocation.analyzer.core.InvalidProfileException;
 import com.engflow.bazel.invocation.analyzer.core.MissingInputException;
 import com.engflow.bazel.invocation.analyzer.core.NullDatumException;
+import com.google.common.collect.ImmutableList;
 import java.util.List;
 
 /**
@@ -32,7 +33,7 @@
 public class FlagValueDataProvider extends DataProvider {
   @Override
   public List<DatumSupplierSpecification<?>> getSuppliers() {
-    return List.of(
+    return ImmutableList.of(
         DatumSupplierSpecification.of(
             FlagValueExperimentalProfileIncludeTargetLabel.class,
             memoized(this::getExperimentalProfileIncludeTargetLabel)));

diff --git a/...zel/invocation/analyzer/dataproviders/FlagValueExperimentalProfileIncludeTargetLabel.java b/...zel/invocation/analyzer/dataproviders/FlagValueExperimentalProfileIncludeTargetLabel.java
@@ -18,8 +18,8 @@
 import java.util.Objects;
 
 /**
- * Whether the Bazel flag `--experimental_profile_include_target_label` was enabled when the Bazel
- * profile was generated.
+ * Whether the Bazel flag {@code --experimental_profile_include_target_label} was enabled when the
+ * Bazel profile was generated.
  *
  * @see <a
  *     href="https://bazel.build/reference/command-line-reference#flag--experimental_profile_include_target_label">Bazel
@@ -64,7 +64,7 @@ public boolean equals(Object o) {
     if (this == o) {
       return true;
     }
-    if (o == null || getClass() != o.getClass()) {
+    if (!(o instanceof FlagValueExperimentalProfileIncludeTargetLabel)) {
       return false;
     }
     FlagValueExperimentalProfileIncludeTargetLabel that =
@@ -79,6 +79,7 @@ public int hashCode() {
 
   @Override
   public String toString() {
-    return String.valueOf(profileIncludeTargetLabelEnabled);
+    return String.format(
+        "FlagValueExperimentalProfileIncludeTargetLabel{%b}", profileIncludeTargetLabelEnabled);
   }
 }