Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
  • Loading branch information
saraadams committed Nov 27, 2023
1 parent bf6d2a2 commit ca2fb3f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

import com.engflow.bazel.invocation.analyzer.traceeventformat.CompleteEvent;

public class BazelEventsUtil {
public final class BazelEventsUtil {
private BazelEventsUtil() {}

/** The event indicates that an action was executed locally. */
Expand All @@ -43,7 +43,7 @@ public static boolean indicatesRemoteExecution(CompleteEvent event) {

/**
* The event documents a remote cache check. This includes cache checks against remote caches
* configured by `--remote_cache` or `--disk_cache`.
* configured by {@code --remote_cache} or {@code --disk_cache}.
*/
public static boolean indicatesRemoteCacheCheck(CompleteEvent event) {
return CAT_REMOTE_ACTION_CACHE_CHECK.equals(event.category);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
* Metrics on remote caching, namely how much time was spent on cache checks, downloading outputs,
* uploading outputs, and what percentage of actions were cached remotely.
*
* <p>Note that Bazel does not differentiate between a remote cache configured via `--disk_cache` or
* `--remote_cache`.
* <p>Note that Bazel does not differentiate between a remote cache configured via {@code
* --disk_cache} or {@code --remote_cache}.
*/
public class RemoteCacheMetrics implements Datum {

Expand Down

0 comments on commit ca2fb3f

Please sign in to comment.