Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using skymeld #91

Closed
saraadams opened this issue Jan 26, 2023 · 1 comment · Fixed by #121
Closed

Suggest using skymeld #91

saraadams opened this issue Jan 26, 2023 · 1 comment · Fixed by #121
Labels
type/feat Suggests new features.

Comments

@saraadams
Copy link
Collaborator

saraadams commented Jan 26, 2023 •
edited
Loading

Problem

Skymeld is a new experimental feature that Bazel users may not be aware of yet.
Include a suggestion to try out skymeld if the profile suggests speed-ups can be expected.

Suggested solution

Also see bazelbuild/bazel#14057
@saraadams saraadams added the type/feat Suggests new features. label Jan 26, 2023
@lrgoldstein
Copy link
Contributor

Note, Skymeld currently breaks some of the existing analysis. #97 should really be implemented before suggesting this be turned on.

@saraadams saraadams mentioned this issue Nov 24, 2023
Merged
saraadams added a commit that referenced this issue Nov 24, 2023
@saraadams
[DataProvider] Add SkymeldUsed Datum and provide it (#116)
f34ee71 
As a first step to supporting Bazel profiles where Skymeld was used, add
a `Datum` that indices whether the profile looks like it was generated
while using Skymeld.

Contributes to #91
Contributes to #97

---------

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams added a commit that referenced this issue Nov 24, 2023
@saraadams
[SuggestionProvider] Suggest using Skymeld
2f5c473 
If the profile indicates Skymeld was not used, suggest enabling it.
A caveat is included if the Bazel profile doesn't report a Bazel version
that supports Skymeld

Fixes #91

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
@saraadams saraadams mentioned this issue Nov 24, 2023
Merged
saraadams added a commit that referenced this issue Nov 27, 2023
@saraadams
[SuggestionProvider] Suggest using Skymeld (#121)
13f1e27 
If the profile indicates Skymeld was not used, suggest enabling it. A
caveat is included if the Bazel profile doesn't report a Bazel version
that supports Skymeld

Fixes #91

Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feat Suggests new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SuggestionProvider] Suggest using Skymeld EngFlow/bazel_invocation_analyzer
2 participants
@saraadams @lrgoldstein