[Skymeld] Adjust DataProviders and SuggestProviders for Skymeld
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraadams
requested review from
lrgoldstein,
restingbull,
TheGrizzlyDev and
WillEngFlow
as code owners
saraadams
force-pushed
the
sara-skymeld-estimated-cores
branch
from
b5ab261
to
9f7e39e
Compare
This change adds support for analysing profiles generated when using Skymeld.
For this, the interlaced analysis and execution phase is split into two parts:
1. Analysis only, no execution interlaced.
2. Execution has started. analysis and execution may be interlaced.
This is done by checking for the first observed `action processing` event.
The distinction is relevant, because it helps us determine how many cores
are available on the machine that ran the Bazel client, as well has how many
cores are used during execution. The later may be higher than the prior,
e.g. when remote execution is used.
* Update `SkymeldUsed` to include the combined analysis and execution phase,
as well as optionally the phase at which execution likely starts.
* Update `EstimatedCoresDataProvider` to estimate cores when Skymeld is used.
* Update `CriticalPathNotDominantSuggestionProvider` when Skymeld is used,
if the information when execution started is available.
Contributes to #97.
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams
force-pushed
the
sara-skymeld-estimated-cores
branch
from
9f7e39e
to
c673354
Compare
ulfjack
approved these changes
Nov 26, 2023
Merged
saraadams
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for analysing profiles generated when using Skymeld. For this, the interlaced analysis and execution phase is split into two parts:
This is done by checking for the first observed
action processingevent. The distinction is relevant, because it helps us determine how many cores are available on the machine that ran the Bazel client, as well has how many cores are used during execution. The later may be higher than the prior, e.g. when remote execution is used.SkymeldUsedto include the combined analysis and execution phase, as well as optionally the phase at which execution likely starts.EstimatedCoresDataProviderto estimate cores when Skymeld is used.CriticalPathNotDominantSuggestionProviderwhen Skymeld is used, if the information when execution started is available.Contributes to #97.