Update external dependencies (jars from maven) #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraadams
requested review from
laszlocsomor,
lrgoldstein and
WillEngFlow
as code owners
saraadams
force-pushed
the
sara-update-external-deps-maven
branch
from
d914f91
to
9bdb7f2
Compare
laszlocsomor
reviewed
Dec 1, 2023
WORKSPACE
Outdated
Comment on lines
108
to
84
| #http_jar( | ||
| # name = "mockito", | ||
| # sha256 = "ee3b91cdf4c23cff92960c32364371c683ee6415f1ec4678317bcea79c9f9819", | ||
| # url = "https://repo1.maven.org/maven2/org/mockito/mockito-core/4.6.1/mockito-core-4.6.1.jar", | ||
| #) | ||
|
|
There was a problem hiding this comment.
Suggested change
| #http_jar( | |
| # name = "mockito", | |
| # sha256 = "ee3b91cdf4c23cff92960c32364371c683ee6415f1ec4678317bcea79c9f9819", | |
| # url = "https://repo1.maven.org/maven2/org/mockito/mockito-core/4.6.1/mockito-core-4.6.1.jar", | |
| #) |
I'm looking into it. It's related to updating byte-buddy. |
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams
force-pushed
the
sara-update-external-deps-maven
branch
from
9bdb7f2
to
54c6713
Compare
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams
force-pushed
the
sara-update-external-deps-maven
branch
from
69a1bf6
to
a2bb7aa
Compare
|
PTAL - I removed mockito and byte-buddy for now. |
WillEngFlow
approved these changes
Dec 1, 2023
|
What could go wrong 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.