Use Bzlmod instead of http_jar in WORKSPACE file #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saraadams
requested review from
laszlocsomor,
lrgoldstein and
WillEngFlow
as code owners
saraadams
force-pushed
the
sara-bzlmod-maven
branch
from
8df0548
to
1ed5f43
Compare
laszlocsomor
reviewed
Dec 4, 2023
| "org.objenesis:objenesis:3.3", | ||
| ], | ||
| repositories = [ | ||
| "https://repo1.maven.org/maven2", |
There was a problem hiding this comment.
Can we mirror these deps to engflow-tools-public, and add its URL?
There was a problem hiding this comment.
We didn't before. Do you think it's necessary?
I understand we do this for our internal repos, but I don't think we have the same requirement for always having 3rd party deps available here.
There was a problem hiding this comment.
I think it's advantageous. Not a blocker. But you never know, maybemaven.org will go down once just the wrong time.
There was a problem hiding this comment.
After discussing outside of this thread, let's not mirror these and add links to our mirror.
laszlocsomor
approved these changes
Dec 4, 2023
Signed-off-by: Sara Adams <sara.e.adams@gmail.com>
saraadams
force-pushed
the
sara-bzlmod-maven
branch
from
1ed5f43
to
6deb15c
Compare
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #154