Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use REST API to get comments #467

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Use REST API to get comments #467

wants to merge 8 commits into from

Conversation

EnricoMi
Copy link
Owner

This removes the use of the GraphQL API to get comments. Minimized information are not used any more.

from copy import deepcopy

from github import Github, GithubException, UnknownObjectException
from github.CheckRun import CheckRun
from github.CheckRunAnnotation import CheckRunAnnotation
from github.PullRequest import PullRequest
from github.PullRequestComment import PullRequestComment
from github.IssueComment import IssueComment
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9% of developers fix this issue

F401: 'github.IssueComment.IssueComment' imported but unused


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@@ -654,7 +655,7 @@ def do_stats_require_comment(earlier_stats_require: Optional[bool], stats_requir

return False

def get_latest_comment(self, pull: PullRequest) -> Optional[IssueComment]:
def get_latest_comment(self, pull: PullRequest) -> Optional[PullRequestComment]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

E501: line too long (84 > 79 characters)

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
python/publish/publisher.py 706
python/publish/publisher.py 718

Visit the Lift Web Console to find more details in your report.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

from copy import deepcopy

from github import Github, GithubException, UnknownObjectException
from github.CheckRun import CheckRun
from github.CheckRunAnnotation import CheckRunAnnotation
from github.PullRequest import PullRequest
from github.PullRequestComment import PullRequestComment
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8% of developers fix this issue

E0401: Unable to import 'github.PullRequestComment'


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

from copy import deepcopy

from github import Github, GithubException, UnknownObjectException
from github.CheckRun import CheckRun
from github.CheckRunAnnotation import CheckRunAnnotation
from github.PullRequest import PullRequest
from github.PullRequestComment import PullRequestComment
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10% of developers fix this issue

reportMissingImports: Import "github.PullRequestComment" could not be resolved


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

from copy import deepcopy

from github import Github, GithubException, UnknownObjectException
from github.CheckRun import CheckRun
from github.CheckRunAnnotation import CheckRunAnnotation
from github.PullRequest import PullRequest
from github.PullRequestComment import PullRequestComment
from github.IssueComment import IssueComment
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21% of developers fix this issue

vulture-90: unused import 'IssueComment'


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Test Results (reference)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Test Results (macOS python 3.8)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux python 3.8)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS 11 python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux 20.04 python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Windows python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Windows 2019 python installed)

       87 files  ±  0         87 suites  ±0   35m 30s ⏱️ +29s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d7d5f87. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@EnricoMi
Copy link
Owner Author

Blocked on next release of PyGithub, remove link to master branch from requirements.txt and git installation from Dockerfile.

Dockerfile Outdated
@@ -12,10 +12,10 @@ LABEL com.github.actions.color="green"
RUN apk add --no-cache --upgrade expat libuuid

COPY python/requirements.txt /action/
RUN apk add --no-cache build-base libffi-dev; \
RUN apk add --no-cache build-base libffi-dev git; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

31% of developers fix this issue

DL3013: Pin versions in pip. Instead of pip install <package> use pip install <package>==<version> or pip install --requirement <requirements file>


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

Dockerfile Outdated
@@ -12,10 +12,10 @@ LABEL com.github.actions.color="green"
RUN apk add --no-cache --upgrade expat libuuid

COPY python/requirements.txt /action/
RUN apk add --no-cache build-base libffi-dev; \
RUN apk add --no-cache build-base libffi-dev git; \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12% of developers fix this issue

DL3018: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@github-actions
Copy link

Test Results (macOS python 3.8)

       87 files  ±  0         87 suites  ±0   35m 37s ⏱️ +36s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit dca99f4. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS python installed)

       87 files  ±  0         87 suites  ±0   35m 37s ⏱️ +36s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit dca99f4. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS 11 python installed)

       87 files  ±  0         87 suites  ±0   35m 37s ⏱️ +36s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit dca99f4. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Test File)

97 tests  ±0   80 ✔️ ±0   3m 25s ⏱️ ±0s
  1 suites ±0   17 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit dca99f4. ± Comparison against base commit afcff83.

@github-actions
Copy link

Test Results (Test Files)

   145 files  ±0       13 errors  735 suites  ±0   2h 12m 37s ⏱️ ±0s
1 811 tests ±0  1 517 ✔️ ±0    73 💤 ±0  210 ±0  11 🔥 ±0 
4 117 runs  ±0  3 428 ✔️ ±0  214 💤 ±0  454 ±0  21 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit dca99f4. ± Comparison against base commit afcff83.

comments = list(pull.get_comments(sort="updated_at", direction="asc"))
else:
comments = list(pull.get_comments())
logger.debug(f'Found {len(comments)} comments for pull request {pull.number}')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

E501: line too long (86 > 79 characters)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@github-actions
Copy link

Test Results (macOS python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS 11 python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Test File)

97 tests  ±0   80 ✔️ ±0   3m 25s ⏱️ ±0s
  1 suites ±0   17 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

@github-actions
Copy link

Test Results (Test Files)

   145 files  ±0       13 errors  735 suites  ±0   2h 12m 37s ⏱️ ±0s
1 811 tests ±0  1 517 ✔️ ±0    73 💤 ±0  210 ±0  11 🔥 ±0 
4 117 runs  ±0  3 428 ✔️ ±0  214 💤 ±0  454 ±0  21 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit d480e2a. ± Comparison against base commit afcff83.

@github-actions
Copy link

Test Results (Dockerfile)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (macOS python 3.8)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Docker Image)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux python 3.8)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Windows 2019 python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Linux 20.04 python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@github-actions
Copy link

Test Results (Windows python installed)

       87 files  ±  0         87 suites  ±0   34m 37s ⏱️ -24s
     421 tests  -   1       421 ✔️  -   1      0 💤 ±0  0 ±0 
36 627 runs   - 87  35 943 ✔️  - 87  684 💤 ±0  0 ±0 

Results for commit d480e2a. ± Comparison against base commit afcff83.

This pull request removes 1 test.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized

@EnricoMi
Copy link
Owner Author

Note: fetches all comments as it cannot sort by updated, requires adding test for get_latest_comment returning latest commit.

comment_id = comments[-1].get("databaseId")
return pull.get_issue_comment(comment_id)
# return latest action comment
return sorted(comments, key=lambda comment: comment.updated_at, reverse=True)[-1]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

E501: line too long (89 > 79 characters)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

.get('pullRequest', {}) \
.get('comments', {}) \
.get('nodes')
def get_pull_request_comments(self, pull: PullRequest) -> List[IssueComment]:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

E501: line too long (81 > 79 characters)


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@github-actions
Copy link

Test Results (macOS python 3.8)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (macOS 11 python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (macOS python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Test File)

97 tests  ±0   80 ✔️ ±0   3m 25s ⏱️ ±0s
  1 suites ±0   17 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

@github-actions
Copy link

Test Results (Test Files)

   145 files  ±0       13 errors  735 suites  ±0   2h 12m 37s ⏱️ ±0s
1 811 tests ±0  1 517 ✔️ ±0    73 💤 ±0  210 ±0  11 🔥 ±0 
4 117 runs  ±0  3 428 ✔️ ±0  214 💤 ±0  454 ±0  21 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 1549e51. ± Comparison against base commit afcff83.

@github-actions
Copy link

Test Results (Dockerfile)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Docker Image)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Linux python 3.8)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Linux 20.04 python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Linux python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Windows python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

@github-actions
Copy link

Test Results (Windows 2019 python installed)

       87 files  ±    0         87 suites  ±0   36m 40s ⏱️ + 1m 39s
     420 tests  -     2       420 ✔️  -     2      0 💤 ±0  0 ±0 
36 540 runs   - 174  35 856 ✔️  - 174  684 💤 ±0  0 ±0 

Results for commit 1549e51. ± Comparison against base commit afcff83.

This pull request removes 2 tests.
python.test.test_publisher.TestPublisher ‑ test_get_action_comments_not_minimized
python.test.test_publisher.TestPublisher ‑ test_get_pull_request_comments_order_updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant