Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECTO release 3-10-2020 #90

Merged
merged 15 commits into from
Mar 17, 2020
Merged

ECTO release 3-10-2020 #90

merged 15 commits into from
Mar 17, 2020

Conversation

laurenechan
Copy link
Collaborator

Updates to patterns for release

@laurenechan
Copy link
Collaborator Author

@matentzn looks like we have some conflicts with the PR, not certain what they mean

@matentzn
Copy link
Contributor

This happens when you are working on a branch that is outdated compared to master. These are the steps:

  1. Go to your release branch (ecto-release-03102020)
  2. Delete the files
src/patterns/data/default/exposure_to_chemical.ofn
src/patterns/data/default/exposure_to_environmental_condition.ofn
src/patterns/data/default/exposure_to_environmental_material.ofn
src/patterns/data/default/exposure_to_environmentalprocess.ofn
src/patterns/definitions.owl

Very important: This is only safe in this case because I know that these are files that are automatically generated (the ofn files are the OWL versions of your patterns, and definitions.owl is the merged ontology of all your ofn files). This is not generally true, especially not if there are files involved that you have actually edited, like ecto-edit.owl or any of tsv are in conflict.

After they are deleted, you need to make sure your release branch is up-to-date with master: https://stackoverflow.com/questions/3876977/update-git-branches-from-master

Lastly, you run your release again, and push it to your release branch. The conflicts will have disappeared.

In a future scenario, where important files are in conflict, contact me again and I will walk you through the proper conflict resolution process, which is very fundamental to working with git!

deletion to resolve conflicts
deletion to resolve conflicts
deletion to resolve conflicts
deletion to resolve conflicts
deletion to resolve conflicts
@laurenechan
Copy link
Collaborator Author

@matentzn are we good to merge the PR now?

@matentzn
Copy link
Contributor

Dont merge yet; I will take care of it. Great work!

Erroneous whitespace in exposure to environmental material pattern
Made sure that disjoint hack works for test (merging ontology first)
- Changed license property, added description (to be OBO conformant).
- removed the `exposure event or process` class from the edit file as this is already in RO and coming from there.
@matentzn matentzn merged commit 8c4ce09 into master Mar 17, 2020
@matentzn matentzn deleted the ecto-release-03102020 branch March 17, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants