Skip to content

Commit

Permalink
Remove unncessary RUN_PANTS_FROM_PEX=0
Browse files Browse the repository at this point in the history
Now that we don't it in the base_build_wheels_env, we don't need to set this.

This was actually causing a failure. ./pants only checks if the env var is set, and not what its value is.
  • Loading branch information
Eric-Arellano committed Feb 19, 2019
1 parent 621137e commit 38e1cf7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ py27_linux_build_wheels_ucs2: &py27_linux_build_wheels_ucs2
-v "${HOME}:/travis/home"
-v "${TRAVIS_BUILD_DIR}:/travis/workdir"
travis_ci_py27_ucs2:latest
sh -c "RUN_PANTS_FROM_PEX=0 ./build-support/bin/ci.sh -2b && RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n"
sh -c "./build-support/bin/ci.sh -2b && RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n"

py27_linux_build_wheels_ucs4: &py27_linux_build_wheels_ucs4
<<: *py27_linux_test_config
Expand Down Expand Up @@ -468,7 +468,7 @@ py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
- ${PYENV_ROOT}/bin/pyenv install 2.7.13
- ${PYENV_ROOT}/bin/pyenv global 2.7.13
script:
- RUN_PANTS_FROM_PEX=0 ./build-support/bin/ci.sh -2b
- ./build-support/bin/ci.sh -2b
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n

# -------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions build-support/travis/travis.yml.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ py27_linux_build_wheels_ucs2: &py27_linux_build_wheels_ucs2
-v "${HOME}:/travis/home"
-v "${TRAVIS_BUILD_DIR}:/travis/workdir"
travis_ci_py27_ucs2:latest
sh -c "RUN_PANTS_FROM_PEX=0 ./build-support/bin/ci.sh -2b && RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n"
sh -c "./build-support/bin/ci.sh -2b && RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n"
py27_linux_build_wheels_ucs4: &py27_linux_build_wheels_ucs4
<<: *py27_linux_test_config
Expand Down Expand Up @@ -444,7 +444,7 @@ py27_osx_build_wheels_ucs4: &py27_osx_build_wheels_ucs4
- ${PYENV_ROOT}/bin/pyenv install 2.7.13
- ${PYENV_ROOT}/bin/pyenv global 2.7.13
script:
- RUN_PANTS_FROM_PEX=0 ./build-support/bin/ci.sh -2b
- ./build-support/bin/ci.sh -2b
- RUN_PANTS_FROM_PEX=1 ./build-support/bin/release.sh -n
# -------------------------------------------------------------------------
Expand Down

0 comments on commit 38e1cf7

Please sign in to comment.