Fix python3.13 deprecation warning #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we've been updating our CI to work with python3.13 in preparation for the upcoming release in October. While doing so we received DeprecationWarnings from
checker.py
passingcount
tore.sub
as a positional argument. It seems in python3.13 this is deprecated due to confusion between flags and count.This PR updates
checker.py
to passre.MULTILINE
tore.sub
with a keywordflags
argument. I think the original code intended for this to be a flag rather than a count. When I tested this withre.MULTILINE
passed as the 4th argument it interpreted it as an integer of 8 and only replaces 8 occurrences ofBLANKLINE_MAKER
.Running the test suite against
main
on python 3.13:Running the test suite against this PR on python 3.13: