Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reachability implementation in samples #1726

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

jared-2016
Copy link
Collaborator

When I ported this over from the plugin, I missed a part which loads the feature Reachability to see if it will provide useful information otherwise it will just return unknown which explains the odd logic in our sample viewer now.

Reverted my last changes.

Description

Type of change

  • Bug fix
  • New sample implementation
  • Sample viewer enhancement
  • Other enhancement

Platforms tested on:

  • Windows
  • Android
  • Linux
  • macOS
  • iOS

Checklist

  • Runs and compiles on all active platforms as a standalone sample
  • Runs and compiles in the sample viewer(s)
  • Branch is up to date with the latest main/v.next
  • All merge conflicts have been resolved
  • Self-review of changes
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files
  • Code is commented with correct formatting (CTRL+i)
  • All variable and method names are camel case
  • There is no leftover commented code
  • Screenshots are correct size and display in description tab (500px by 500px, platform agnostic)
  • If adding a new sample, it is added to the sample viewer
  • Cherry-picked to Main branch (if applicable)

@jared-2016 jared-2016 self-assigned this Jun 26, 2024
@jared-2016 jared-2016 merged commit 527e6fa into v.next Jun 26, 2024
@jared-2016 jared-2016 deleted the jared/ughDownloads branch June 26, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants